feat: add configurable JWT issuer for local auth development #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be also configurable via |
|
Yes, similar to any other auth env variables, this will be also parsed by auth server 👍 |
Pull Request Test Coverage Report for Build 18940990217Details
💛 - Coveralls |
| fmt.Sprintf("GOTRUE_JWT_EXP=%v", utils.Config.Auth.JwtExpiry), | ||
| "GOTRUE_JWT_SECRET=" + utils.Config.Auth.JwtSecret.Value, | ||
| "GOTRUE_JWT_ISSUER=" + utils.GetApiUrl("/auth/v1"), | ||
| "GOTRUE_JWT_ISSUER=" + jwtIssuer, |
There was a problem hiding this comment.
Suggested change
| "GOTRUE_JWT_ISSUER=" + jwtIssuer, | |
| "GOTRUE_JWT_ISSUER=" + utils.Config.Auth.JwtIssuer, |
Just a nitpick: I think we should apply the default value when loading config in case we need to use this value in other places in the future.
Comment on lines
502
to
505
| "GOTRUE_MAILER_URLPATHS_INVITE=" + utils.GetApiUrl("/auth/v1/verify"), | ||
| "GOTRUE_MAILER_URLPATHS_CONFIRMATION=" + utils.GetApiUrl("/auth/v1/verify"), | ||
| "GOTRUE_MAILER_URLPATHS_RECOVERY=" + utils.GetApiUrl("/auth/v1/verify"), | ||
| "GOTRUE_MAILER_URLPATHS_EMAIL_CHANGE=" + utils.GetApiUrl("/auth/v1/verify"), |
There was a problem hiding this comment.
Do we need to update these as well? Basically to use Config.Auth.JwtIssuer as the base url for every auth callback that user expects to load from their browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
jwt_issuerfield to auth configuration in config.tomlMotivation
When developing OAuth integrations, the auth server OAuth discovery endpoint
/.well-known/oauth-authorization-serverreturns URLs referencinglocalhost, which are inaccessible to third-party services trying to integrate with the local instance.This change allows developers to configure the issuer url for the auth server, making it possible to test third-party OAuth integrations locally without deploying to a remote environment.
Relevant: https://github.com/orgs/supabase/discussions/38022#discussioncomment-14815820