@@ -28,8 +28,8 @@ constructive, respectful and helpful reviews and replies.
2828 welcoming place for everyone. **You are free to disagree with
2929 someone's opinions, but don't be disrespectful. **
3030
31- First of, accept that many programming decisions are opinions.
32- Discuss trade offs, which you prefer, and reach a resolution quickly.
31+ It’s important to accept that many programming decisions are opinions.
32+ Discuss trade- offs, which you prefer, and reach a resolution quickly.
3333It's not about being right or wrong, but using what works.
3434
3535Tone of Voice
@@ -118,13 +118,13 @@ If a piece of code is in fact wrong, explain why:
118118* "We only provide integration with very popular projects (e.g. we integrate Bootstrap but not your own CSS framework)"
119119
120120* "This would require adding lots of code and making lots of changes for a feature that doesn't look so important.
121- That could hurt maintaining in the future."
121+ That could hurt maintenance in the future."
122122
123123Asking for Changes
124124------------------
125125
126126Rarely something is perfect from the start, while the code itself is good.
127- It may not be optimal or conform the Symfony coding style.
127+ It may not be optimal or conform to the Symfony coding style.
128128
129129Again, understand the author already spent time on the issue and asking
130130for (small) changes may be misinterpreted or seen as a personal attack.
@@ -143,7 +143,7 @@ Use words like "Please", "Thank you" and "Could you" instead of making demands;
143143
144144* "Please use 4 spaces instead of tabs", "This needs be on the previous line";
145145
146- During a pull request review you can usually leave more then one comment,
146+ During a pull request review you can usually leave more than one comment,
147147you don't have to use "Please" all the time. But it wouldn't hurt.
148148
149149It may not seem like much, but saying "Thank you" does make others feel
@@ -158,7 +158,7 @@ In that case, it is better to try to approach the discussion in
158158a different way, to not escalate further.
159159
160160If you want someone to mediate, please join the ``#contribs `` channel on `Symfony Slack `_,
161- to have a safe environment and keep working together on the common goals.
161+ to have a safe environment and keep working together on common goals.
162162
163163Using Humor
164164-----------
@@ -172,8 +172,8 @@ to the Symfony community.** And don't marginalize someone's problems;
172172
173173Even if someone's explanation is "inviting to joke about it", it's a real
174174problem to them. Making jokes about this doesn't help with solving their
175- problem and only makes them *feel stupid *. Instead try to discover what
176- the problem is really about .
175+ problem and only makes them *feel stupid *. Instead, try to discover the
176+ actual problem.
177177
178178Final Words
179179-----------
0 commit comments