bug #59671 [Yaml] Yaml::DUMP_COMPACT_NESTED_MAPPING does not apply when dumping sequences (xabbuh)

This PR was squashed before being merged into the 7.3 branch.

Discussion
----------

[Yaml] Yaml::DUMP_COMPACT_NESTED_MAPPING does not apply when dumping sequences

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

following #59315, the flag should only affect how maps are dumped but shouldn't influence dumping sequences (see also symfony/symfony-docs#20510 (comment))

Commits
-------

0c124a99e91 [Yaml] Yaml::DUMP_COMPACT_NESTED_MAPPING does not apply when dumping sequences

Author: nicolas-grekas

Dumper.php

@@ -135,8 +135,8 @@ private function doDump(mixed $input, int $inline = 0, int $indent = 0, int $fla
                 $output .= \sprintf('%s%s%s%s',
                     $prefix,
                     $dumpAsMap ? Inline::dump($key, $flags).':' : '-',
-                    $willBeInlined || ($compactNestedMapping && \is_array($value)) ? ' ' : "\n",
-                    $compactNestedMapping && \is_array($value) ? substr($this->doDump($value, $inline - 1, $indent + 2, $flags, $nestingLevel + 1), $indent + 2) : $this->doDump($value, $inline - 1, $willBeInlined ? 0 : $indent + $this->indentation, $flags, $nestingLevel + 1)
+                    $willBeInlined || ($compactNestedMapping && \is_array($value) && Inline::isHash($value)) ? ' ' : "\n",
+                    $compactNestedMapping && \is_array($value) && Inline::isHash($value) ? substr($this->doDump($value, $inline - 1, $indent + 2, $flags, $nestingLevel + 1), $indent + 2) : $this->doDump($value, $inline - 1, $willBeInlined ? 0 : $indent + $this->indentation, $flags, $nestingLevel + 1)
                 ).($willBeInlined ? "\n" : '');
             }
         }

Tests/DumperTest.php

@@ -1085,38 +1085,122 @@ public static function getDumpCompactNestedMapping()
                 ],
             ],
         ];
-        $expected = <<<YAML
+
+        yield 'Compact nested mapping 1' => [
+            $data,
+            <<<YAML
 planets:
-\t- name: Mercury
-\t  distance: 57910000
-\t  properties:
-\t\t  - name: size
-\t\t    value: 4879
-\t\t  - name: moons
-\t\t    value: 0
-\t\t  - - - {  }
-\t- name: Jupiter
-\t  distance: 778500000
-\t  properties:
-\t\t  - name: size
-\t\t    value: 139820
-\t\t  - name: moons
-\t\t    value: 79
-\t\t  - - {  }
+ - name: Mercury
+   distance: 57910000
+   properties:
+    - name: size
+      value: 4879
+    - name: moons
+      value: 0
+    -
+     -
+      - {  }
+ - name: Jupiter
+   distance: 778500000
+   properties:
+    - name: size
+      value: 139820
+    - name: moons
+      value: 79
+    -
+     - {  }
 
-YAML;
+YAML,
+            1,
+        ];
 
-        for ($indentation = 1; $indentation < 5; ++$indentation) {
-            yield \sprintf('Compact nested mapping %d', $indentation) => [
-                $data,
-                strtr($expected, ["\t" => str_repeat(' ', $indentation)]),
-                $indentation,
-            ];
-        }
+        yield 'Compact nested mapping 2' => [
+            $data,
+            <<<YAML
+planets:
+  - name: Mercury
+    distance: 57910000
+    properties:
+      - name: size
+        value: 4879
+      - name: moons
+        value: 0
+      -
+        -
+          - {  }
+  - name: Jupiter
+    distance: 778500000
+    properties:
+      - name: size
+        value: 139820
+      - name: moons
+        value: 79
+      -
+        - {  }
+
+YAML,
+            2,
+        ];
 
-        $indentation = 2;
-        $inline = 4;
-        $expected = <<<YAML
+        yield 'Compact nested mapping 3' => [
+            $data,
+            <<<YAML
+planets:
+   - name: Mercury
+     distance: 57910000
+     properties:
+        - name: size
+          value: 4879
+        - name: moons
+          value: 0
+        -
+           -
+              - {  }
+   - name: Jupiter
+     distance: 778500000
+     properties:
+        - name: size
+          value: 139820
+        - name: moons
+          value: 79
+        -
+           - {  }
+
+YAML,
+            3,
+        ];
+
+        yield 'Compact nested mapping 4' => [
+            $data,
+            <<<YAML
+planets:
+    - name: Mercury
+      distance: 57910000
+      properties:
+          - name: size
+            value: 4879
+          - name: moons
+            value: 0
+          -
+              -
+                  - {  }
+    - name: Jupiter
+      distance: 778500000
+      properties:
+          - name: size
+            value: 139820
+          - name: moons
+            value: 79
+          -
+              - {  }
+
+YAML,
+            4,
+        ];
+
+        yield 'Compact nested mapping 2 and inline 4' => [
+            $data,
+            <<<YAML
 planets:
   - name: Mercury
     distance: 57910000
@@ -1131,13 +1215,9 @@ public static function getDumpCompactNestedMapping()
       - { name: moons, value: 79 }
       - [{  }]
 
-YAML;
-
-        yield \sprintf('Compact nested mapping %d and inline %d', $indentation, $inline) => [
-            $data,
-            $expected,
-            $indentation,
-            $inline,
+YAML,
+            2,
+            4,
         ];
     }