From b091fd30b18fb42e53619d81a0e3e3ac6896d211 Mon Sep 17 00:00:00 2001 From: Justin Kerney Date: Sat, 16 Sep 2023 21:31:55 +1000 Subject: [PATCH 1/2] Update tg_fastRP.gsql - bug fix for choose_k parameter --- algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql b/algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql index fa78bef3..74ed787a 100644 --- a/algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql +++ b/algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql @@ -273,4 +273,8 @@ CREATE QUERY tg_fastRP( IF result_attribute != "" THEN storeEmbeddings = SELECT s FROM verts:s POST-ACCUM s.setAttr(result_attribute, s.@final_embedding_list); END; + + sample_verts = + SELECT s FROM verts:s LIMIT choose_k; + PRINT sample_verts; } From 6e57c7bce9bcfed3898a99c2bb3ee5c34821bb5b Mon Sep 17 00:00:00 2001 From: Justin Kerney Date: Sat, 16 Sep 2023 21:52:49 +1000 Subject: [PATCH 2/2] Update tg_fastRP.gsql - bug fix for print_results parameter Bug fix for print_results parameter. When this parameter is set to TRUE, the script should print all node embeddings results. However all node embeddings will be zero due to the line s.@final_embedding_arr.clear(). The fix is to remove this line. Since this line is towards the end in the code, impact to memory consumption should be minimal. --- algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql b/algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql index 74ed787a..11dd771d 100644 --- a/algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql +++ b/algorithms/GraphML/Embeddings/FastRP/tg_fastRP.gsql @@ -260,8 +260,7 @@ CREATE QUERY tg_fastRP( POST-ACCUM FOREACH i IN RANGE[0, embedding_dimension-1] DO s.@final_embedding_list += s.@final_embedding_arr.get(i) / @@weights.size() // Average by # of iterations - END, - s.@final_embedding_arr.clear(); + END; IF print_results THEN res = SELECT a FROM verts:a;