KeyManagement Tests added and services marked as private

Author: Spomky

src/Bundle/Checker/Resources/config/checkers.yml

@@ -2,25 +2,25 @@ services:
     _defaults:
         autowire: true
         autoconfigure: true
+        public: false
+
+    Jose\Component\Checker\HeaderCheckerManagerFactory:
         public: true
 
-    Jose\Component\Checker\HeaderCheckerManagerFactory: ~
-    Jose\Component\Checker\ClaimCheckerManagerFactory: ~
+    Jose\Component\Checker\ClaimCheckerManagerFactory:
+        public: true
 
     Jose\Component\Checker\ExpirationTimeChecker:
-        public: false
         tags:
             - { name: 'jose.checker.header', alias: 'exp' }
             - { name: 'jose.checker.claim', alias: 'exp' }
 
     Jose\Component\Checker\IssuedAtChecker:
-        public: false
         tags:
             - { name: 'jose.checker.header', alias: 'iat' }
             - { name: 'jose.checker.claim', alias: 'iat' }
 
     Jose\Component\Checker\NotBeforeChecker:
-        public: false
         tags:
             - { name: 'jose.checker.header', alias: 'nbf' }
             - { name: 'jose.checker.claim', alias: 'nbf' }

src/Bundle/Console/Resources/config/analyzers.yml

@@ -2,7 +2,7 @@ services:
     _defaults:
         autowire: true
         autoconfigure: true
-        public: true
+        public: false
 
     Jose\Component\KeyManagement\KeyAnalyzer\JWKAnalyzerManager: ~
 

src/Bundle/Console/Resources/config/commands.yml

@@ -2,7 +2,7 @@ services:
     _defaults:
         autowire: true
         autoconfigure: true
-        public: true
+        public: false
 
     Jose\Component\Console\EcKeyGeneratorCommand:
         tags:

src/Bundle/Encryption/Resources/config/algorithms.yml

@@ -2,7 +2,7 @@ services:
     _defaults:
         autowire: true
         autoconfigure: true
-        public: true
+        public: false
 
     Jose\Component\Encryption\Algorithm\ContentEncryption\A128CBCHS256:
         tags:

src/Bundle/Encryption/Resources/config/compression_methods.yml

@@ -2,7 +2,7 @@ services:
     _defaults:
         autowire: true
         autoconfigure: true
-        public: true
+        public: false
 
     Jose\Component\Encryption\Compression\Deflate:
         tags:

src/Bundle/Encryption/Resources/config/serializers.yml

@@ -2,7 +2,7 @@ services:
     _defaults:
         autowire: true
         autoconfigure: true
-        public: true
+        public: false
 
     Jose\Component\Encryption\Serializer\JWESerializerManagerFactory: ~
     Jose\Component\Encryption\Serializer\CompactSerializer:

src/Bundle/Encryption/Resources/config/services.yml

@@ -2,10 +2,14 @@ services:
     _defaults:
         autowire: true
         autoconfigure: true
+        public: false
+
+    Jose\Component\Encryption\JWEBuilderFactory:
+        public: true
+
+    Jose\Component\Encryption\JWELoaderFactory:
         public: true
 
-    Jose\Component\Encryption\JWEBuilderFactory: ~
-    Jose\Component\Encryption\JWELoaderFactory: ~
     Jose\Component\Encryption\Compression\CompressionMethodManagerFactory: ~
     Jose\Component\Encryption\JWETokenHeaderChecker:
         tags:

src/Bundle/Encryption/Tests/JWEComputationTest.php

@@ -13,6 +13,7 @@
 
 namespace Jose\Bundle\Encryption\Tests;
 
+use Jose\Component\Core\Converter\StandardJsonConverter;
 use Jose\Component\Core\JWK;
 use Jose\Component\Encryption\JWEBuilder;
 use Jose\Component\Encryption\JWELoader;
@@ -41,8 +42,7 @@ public function testCreateAndLoadAToken()
         /** @var JWELoader $loader */
         $loader = $container->get('jose.jwe_loader.loader1');
 
-        /** @var CompactSerializer $serializer */
-        $serializer = $container->get(CompactSerializer::class);
+        $serializer = new CompactSerializer(new StandardJsonConverter());
 
         $jwe = $builder
             ->create()
@@ -82,8 +82,7 @@ public function testUnableToLoadAnExpiredToken()
         /** @var JWELoader $loader */
         $loader = $container->get('jose.jwe_loader.loader1');
 
-        /** @var CompactSerializer $serializer */
-        $serializer = $container->get(CompactSerializer::class);
+        $serializer = new CompactSerializer(new StandardJsonConverter());
 
         $jwe = $builder
             ->create()

src/Bundle/JoseFramework/Resources/config/json_converter.yml

@@ -2,6 +2,6 @@ services:
     _defaults:
         autowire: true
         autoconfigure: true
-        public: true
+        public: false
 
     Jose\Component\Core\Converter\StandardJsonConverter: ~

src/Bundle/JoseFramework/Resources/config/services.yml

@@ -2,7 +2,7 @@ services:
     _defaults:
         autowire: true
         autoconfigure: true
-        public: true
+        public: false
 
     Jose\Component\Core\AlgorithmManagerFactory: ~
     Jose\Bundle\JoseFramework\DataCollector\JoseCollector:
@@ -11,4 +11,3 @@ services:
                 name:     data_collector
                 template: '@JoseFramework/data_collector/template.html.twig'
                 id:       'jose_collector'
-        public: false