From aaec2d986fc34c45e8af45adb79288d3c5c4d612 Mon Sep 17 00:00:00 2001 From: Pawan Kumar Date: Mon, 21 Nov 2022 19:04:42 +0530 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=90=9B=20fix(progress=20bar):=20progr?= =?UTF-8?q?essbar=20harbar=20error=20fix.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../docs/progress-bar-elements.stories.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-progress-bar/docs/progress-bar-elements.stories.js b/packages/react-progress-bar/docs/progress-bar-elements.stories.js index 23c64e2d..cfc68c97 100644 --- a/packages/react-progress-bar/docs/progress-bar-elements.stories.js +++ b/packages/react-progress-bar/docs/progress-bar-elements.stories.js @@ -114,7 +114,7 @@ export const Loader = () => { ]} isLast={true} > - + ); }; @@ -132,7 +132,7 @@ export const Percent = () => { ]} isLast={true} > - + ); }; @@ -152,7 +152,7 @@ export const Cancel = () => { ]} isLast={true} > - + ); }; From ef3a61c4370f72048f5f964fe0cbdc8e80d0be2c Mon Sep 17 00:00:00 2001 From: Pawan Kumar Date: Tue, 22 Nov 2022 11:26:37 +0530 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=90=9B=20fix(progress=20bar):=20progr?= =?UTF-8?q?ess=20bar=20description=20array=20key=20fix.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../docs/progress-bar-elements.stories.js | 54 +++++++------------ .../docs/progress-bar-modifiers.stories.js | 20 +++---- 2 files changed, 30 insertions(+), 44 deletions(-) diff --git a/packages/react-progress-bar/docs/progress-bar-elements.stories.js b/packages/react-progress-bar/docs/progress-bar-elements.stories.js index cfc68c97..ae7d5e7b 100644 --- a/packages/react-progress-bar/docs/progress-bar-elements.stories.js +++ b/packages/react-progress-bar/docs/progress-bar-elements.stories.js @@ -105,13 +105,11 @@ export const Loader = () => { return (
hasLoader, - ' property to ', - false, - '.', - ]} + description={ + <> + By default, the component shows the loading wheel but you can hide it by setting hasLoader property to false. + + } isLast={true} > @@ -123,13 +121,11 @@ export const Percent = () => { return (
hasLabel, - ' property to ', - false, - '.', - ]} + description={ + <> + By default, the component shows the progress value or percentage, but you can hide it by setting hasLabel property to false. + + } isLast={true} > @@ -141,15 +137,11 @@ export const Cancel = () => { return (
hasCancel, - ' property to ', - false, - '. You can also pass a function when clicking on it by using the ', - cbFunction, - ' property.', - ]} + description={ + <> + By default, the component shows the cancel button, but you can hide it by setting hasCancel property to false. You can also pass a function when clicking on it by using the cbFunction property. + + } isLast={true} > @@ -162,17 +154,11 @@ export const Legend = () => { <>
hasFrame, - ' and ', - hasLegend, - ' properties are set to ', - true, - '. You can edit the text using ', - sourceLang, - ' property.', - ]} + description={ + <> + This text appears below the progress bar and only when hasFrame and hasLegend properties are set to true. You can edit the text using sourceLang property. + + } isLast={true} > {
hasFrame, - ' property, you can display a gray border with inner spacing around the progress bar and its elements.', - ]} + description={ + <> + Using the hasFrame property, you can display a gray border with inner spacing around the progress bar and its elements. + + } code="<ProgressBar now={ 30 } hasFrame={ true } hasLegend={ false } />" > @@ -127,11 +127,11 @@ export const Design = () => {
hasLegend, - ' property.', - ]} + description={ + <> + The boxed variation can come with a legend at the bottom if necessary that you can display using the hasLegend property. + + } code="<ProgressBar now={ 30 } hasFrame={ true } hasLegend={ true } />" isLast={true} >