drivers: usb: udc: stm32: use instance MPS for IN endpoints capabilities #98495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuchopstm
added
bug
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
jfischer-no,
marwaiehm-st and
tmon-nordic
etienne-lms
approved these changes
Oct 29, 2025
jfischer-no
removed
Trivial
jfischer-no
approved these changes
Oct 29, 2025
When setting endpoint capabilities, the driver uses the MPS stored in each instance's configuration for OUT endpoints, but used a hardcoded 1023 for IN endpoints. Use the instance MPS when preparing IN endpoints' capabilities too. Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
mathieuchopstm
force-pushed
the
stm32_usb_fix_ep_in_mps
branch
from
7dacb0f to
3cde2c7
Compare
|
rebased to fix CI failure |
|
|
Added @etienne-lms as assignee as @erwango is out of office and can't approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting endpoint capabilities, the driver uses the MPS stored in each instance's configuration for OUT endpoints, but used a hardcoded 1023 for IN endpoints.
Use the instance MPS when preparing IN endpoints' capabilities too.