Skip to content

Rutefig/reg 574 fix prevent capture groups inside of private patterns #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2025
Merged

Rutefig/reg 574 fix prevent capture groups inside of private patterns #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89c9442
fix: rust compilation errors - unstable expressions
rutefig Oct 30, 2025
181ddd8
chore: convert bare capture groups on private patterns into non captu…
rutefig Oct 30, 2025
12b8a6f
fix: doctest trying to access to private function
rutefig Oct 30, 2025
bb530c5
chore: added test to check if gen_from_decomposed converts capture gr…
rutefig Oct 30, 2025
faeabb4
fix: properly handle escaped parens and character classes in capture …
rutefig Oct 30, 2025
dfe8085
fix: convert named captures to non-capturing in private patterns
rutefig Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions compiler/src/ir/graph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,11 @@ impl NFAGraph {
// Start from accept states
let mut stack: Vec<_> = self.accept_states.iter().copied().collect();
while let Some(state) = stack.pop() {
if reaching_accept.insert(state)
&& let Some(predecessors) = reverse_edges.get(&state) {
if reaching_accept.insert(state) {
if let Some(predecessors) = reverse_edges.get(&state) {
stack.extend(predecessors);
}
}
}

reaching_accept
Expand Down
5 changes: 3 additions & 2 deletions compiler/src/ir/intermediate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ impl IntermediateNFA {
.unwrap_or(false);

// Only add alternative start states if no start captures would be bypassed
if !has_start_captures
&& let Some(closure) = closures.get(orig_start) {
if !has_start_captures {
if let Some(closure) = closures.get(orig_start) {
for &r_state in &closure.states {
if r_state != orig_start
&& r_state < has_byte_transitions.len()
Expand All @@ -229,6 +229,7 @@ impl IntermediateNFA {
}
}
}
}
}

// Apply the changes
Expand Down
Loading
Loading