button: Replace GestureDetector with Listener for AnimatedScaleOnTap
#1954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zulip#1953. Latter provides instant scaleDown animation on tap, unlike GestureDetector which has a `kPressTimeOut` causing delay of 100ms https://main-api.flutter.dev/flutter/gestures/kPressTimeout-constant.html
MritunjayTiwari14
force-pushed
the
navbar_resp
branch
from
7710b5d to
7034690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1953.
The Scale down and Scale up as well as Ink Splash animation occurs after a finite delay of 100ms. Mainly due to
GestureDetectorused insideAnimatedScaleOnTap.This can be fixed by using
Listenerhence replacing theGestureDetectorinsideAnimatedScaleOnTap.Discussion: #mobile > issue in responsiveness of home bottom navbar icons
Design: Figma Design
Comparison Through Video of Fix-up
Before
implementation.mp4
After
fixup.mp4