Skip to content

Fix/parallel docker login #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sprint-1.17
Choose a base branch
from
+22 −8
Open

Fix/parallel docker login #1475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc0b63
Merge pull request #1470 from 0chain/sprint-1.17
dabasov Aug 29, 2024
28fcfe5
Update build-&-publish-docker-image.yml
shahnawaz-creator Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions .github/workflows/build-&-publish-docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,13 @@ jobs:
uses: docker/setup-buildx-action@v3

- name: Login to Docker Hub
uses: docker/login-action@v1
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
run: |
mkdir -p /tmp/docker-config-${{ github.run_id }}
docker --config /tmp/docker-config-${{ github.run_id }} login -u ${{ secrets.DOCKERHUB_USERNAME }} -p ${{ secrets.DOCKERHUB_PASSWORD }}
# uses: docker/login-action@v1
# with:
# username: ${{ secrets.DOCKERHUB_USERNAME }}
# password: ${{ secrets.DOCKERHUB_PASSWORD }}

# - name: Get changed files using defaults
# id: changed-files
Expand Down Expand Up @@ -96,6 +99,10 @@ jobs:
docker tag ${BLOBBER_REGISTRY}:${TAG} ${BLOBBER_REGISTRY}:${TAG}-${SHORT_SHA}
docker push ${BLOBBER_REGISTRY}:${TAG}-${SHORT_SHA}

- name: Clean up Docker Config
run: |
rm -rf /tmp/docker-config-${{ github.run_id }}

validator:
timeout-minutes: 30
runs-on: [blobber-runner]
Expand Down Expand Up @@ -124,10 +131,13 @@ jobs:
# go-version: ^1.21 # The Go version to download (if necessary) and use.

- name: Login to Docker Hub
uses: docker/login-action@v1
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
run: |
mkdir -p /tmp/docker-config-${{ github.run_id }}
docker --config /tmp/docker-config-${{ github.run_id }} login -u ${{ secrets.DOCKERHUB_USERNAME }} -p ${{ secrets.DOCKERHUB_PASSWORD }}
# uses: docker/login-action@v1
# with:
# username: ${{ secrets.DOCKERHUB_USERNAME }}
# password: ${{ secrets.DOCKERHUB_PASSWORD }}

- name: Clone blobber
uses: actions/checkout@v3
Expand Down Expand Up @@ -173,6 +183,10 @@ jobs:
docker tag ${VALIDATOR_REGISTRY}:${TAG} ${VALIDATOR_REGISTRY}:${TAG}-${SHORT_SHA}
docker push ${VALIDATOR_REGISTRY}:${TAG}-${SHORT_SHA}

- name: Clean up Docker Config
run: |
rm -rf /tmp/docker-config-${{ github.run_id }}

system-tests:
if: github.event_name != 'workflow_dispatch'
needs: [blobber, validator]
Expand Down