Code quality: Check if location access is permitted #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (288 of 288 strings) Co-authored-by: Martin Wilichowski <martin.wilichowski@gmx.de> Translate-URL: https://hosted.weblate.org/projects/auto-dark-mode/app/de/ Translation: Auto Dark Mode/App
Currently translated at 99.3% (286 of 288 strings) Co-authored-by: hugoalh <hugoalh@users.noreply.hosted.weblate.org> Translate-URL: https://hosted.weblate.org/projects/auto-dark-mode/app/zh_Hant/ Translation: Auto Dark Mode/App
Currently translated at 86.1% (248 of 288 strings) Co-authored-by: Moji <moj.enjoy@gmail.com> Translate-URL: https://hosted.weblate.org/projects/auto-dark-mode/app/fa/ Translation: Auto Dark Mode/App
Currently translated at 100.0% (288 of 288 strings) Translated using Weblate (Chinese (Simplified Han script)) Currently translated at 100.0% (288 of 288 strings) Co-authored-by: Kazuto Iris <78157415+kazutoiris@users.noreply.github.com> Translate-URL: https://hosted.weblate.org/projects/auto-dark-mode/app/zh_Hans/ Translation: Auto Dark Mode/App
Currently translated at 84.3% (243 of 288 strings) Co-authored-by: Daniel <daniel-sevillano@hotmail.com> Translate-URL: https://hosted.weblate.org/projects/auto-dark-mode/app/es/ Translation: Auto Dark Mode/App
Currently translated at 98.2% (283 of 288 strings) Co-authored-by: turi1122 <61917421+turi1122@users.noreply.github.com> Translate-URL: https://hosted.weblate.org/projects/auto-dark-mode/app/hu/ Translation: Auto Dark Mode/App
ChenYiLins
requested review from
a team,
Armin2208 and
Spiritreader
as code owners
|
Thanks for making this change!!! <3 Again the wording: |
|
I have busy days on Thursday and Friday. Maybe more time in the weekend... |
…te/Windows-Auto-Night-Mode into checklocationaccess # Conflicts: # AutoDarkModeApp/Strings/fa/Resources.resw # AutoDarkModeApp/Strings/hu/Resources.resw # AutoDarkModeApp/Strings/zh-hans/Resources.resw # AutoDarkModeApp/Strings/zh-hant/Resources.resw
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add InfoBar. When the user clicks the confirm button, it will jump to the settings. (InfoBar is used because users do not have to be forced to open location services, which is their own choice)
Screenshots