Add NVA In VNet support for Network VirtualAppliance #28776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)update mapper 3)add check for either virtualhub or nvanicinterfaceconfig property exists
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Network Virtual Appliance (NVA) interface configurations for NVAs deployed in VNet. The key changes enable users to configure network interface settings for NVAs that are deployed directly into virtual networks, as an alternative to deploying them into virtual hubs.
- Adds new model classes for NVA interface configurations
- Introduces two new cmdlets for creating interface configurations
- Updates the
New-AzNetworkVirtualAppliancecmdlet to support the new interface configuration parameter - Includes AutoMapper configurations for bidirectional mapping between PowerShell and SDK models
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| NewNetworkVirtualApplianceCommand.cs | Modified to make VirtualHubId optional, added NvaInterfaceConfigurations parameter, and added mutual exclusivity validation |
| NvaInVnetBaseCmdlet.cs | New base class for NVA-in-VNet cmdlets (placeholder for future functionality) |
| NewNvaInterfaceConfigurationsCommand.cs | New cmdlet to build multiple interface configurations from an array |
| NewNvaInterfaceConfigurationCommand.cs | New cmdlet to build individual interface configuration objects |
| Network.generated.format.ps1xml | Updated formatting definition to display NvaInterfaceConfigurations property |
| Network.format.ps1xml | Updated formatting definition to display NvaInterfaceConfigurations property |
| PSNetworkVirtualApplianceInterfaceConfig.cs | New model classes for interface configurations |
| PSNetworkVirtualAppliance.cs | Added NvaInterfaceConfigurations property to the model |
| NetworkResourceManagerProfile.cs | Added AutoMapper configurations for bidirectional mapping of interface configuration models |
| ChangeLog.md | Documented the new feature and cmdlets |
| Az.Network.psd1 | Exported the two new cmdlets |
src/Network/Network/NetworkVirtualAppliance/NewNetworkVirtualApplianceCommand.cs
Outdated
Show resolved
Hide resolved
src/Network/Network/NetworkVirtualAppliance/NewNetworkVirtualApplianceCommand.cs
Show resolved
Hide resolved
src/Network/Network/NetworkVirtualAppliance/NVAInVnet/NewNvaInterfaceConfigurationsCommand.cs
Outdated
Show resolved
Hide resolved
src/Network/Network/NetworkVirtualAppliance/NVAInVnet/NewNvaInterfaceConfigurationCommand.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…pplianceCommand.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…terfaceConfigurationsCommand.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…terfaceConfigurationCommand.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
…onfig.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Azure Pipelines successfully started running 3 pipeline(s). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
correct indentation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
correct indentation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
correct indentation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
correct indentation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
correct indentation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
correct indentation Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Was mistakenly added for reviewing the PR, I am not from PS team, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.