Sync eng/common directory with azure-sdk-tools for PR 12569 #53509
+1,187
−2,253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools for PR 12569, updating the spell checking tooling to use a newer version of cspell and refactoring the implementation approach. The key changes include:
- Upgrading cspell from version 6.12.0 to 9.2.1 and removing redundant bundled dictionary dependencies
- Refactoring
Invoke-Cspell.ps1to accept file lists via stdin instead of using glob patterns - Updating the caller script to use the new
-FileListparameter
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/spelling/package.json | Upgrades cspell to version 9.2.1 and simplifies dependencies by removing bundled dictionaries |
| eng/common/spelling/Invoke-Cspell.ps1 | Refactors the script to use stdin-based file input with PowerShell pipeline support instead of glob-based scanning |
| eng/common/scripts/check-spelling-in-changed-files.ps1 | Updates parameter name from ScanGlobs to FileList to align with refactored implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12569 See eng/common workflow