Skip to content

Conversation

@pratik97
Copy link
Contributor

@pratik97 pratik97 commented Sep 1, 2021

What has Changed?

Fixes #

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

  • Made sure the PR is directed at the dev branch (unless reasons).
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • Read the source changes.
  • Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • If need be, had a chat within the team about particular changes.

Ping @PEZ, @bpringe

@bpringe bpringe changed the base branch from published to dev September 4, 2021 18:04
@bpringe
Copy link
Member

bpringe commented Sep 4, 2021

@pratik97 Is this meant to be a draft / work-in-progress at this point, or is it ready for review? Judging by the PR description lacking information and some checklist items not being completed, I'm guessing it's a WIP.

@pratik97
Copy link
Contributor Author

pratik97 commented Sep 4, 2021

@bpringe yes, it's a draft, it is only meant for getting early feedback on the path I was going with to implement the load all files feature. I was unsure of the performance considerations and the way we show that the files have been loaded.

I had mentioned this on a slack to @PEZ but I should have marked this PR as a WIP as it's far away from review stage 😅

@frankleonrose
Copy link

Is this a proposed solution to #1278 or merely related? I'm unclear whether "loading" means opening an editor or loading the namespace into the repl.

@riotrah riotrah marked this pull request as draft April 13, 2022 22:18
@bpringe
Copy link
Member

bpringe commented Apr 17, 2022

@frankleonrose Judging by the changes it looks like it's about loading the file in the repl.

@pratik97
Copy link
Contributor Author

Yes, it's about loading all the files in REPL using one command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants