[wip] feat: uses latest version of depencies for jack-in #2960

afucher · 2025-10-24T22:35:17Z

What has changed?

Jack-in now auto-fetches the latest nREPL, cider-nrepl, and piggieback versions on first startup (via clojure/deps; falls back to deps.clj), caches them in global state, and falls back to built-in defaults if fetching fails.
- The fall back to deps.clj is because Calva already have deps.clj.jar, but can be removed. I added because I thought that was a nice quickwin here.
User overrides remain the highest priority; effective resolution is: overrides → cached latest → built-in defaults.
New module src/nrepl/jack-in-dependency-versions.ts implements fetching, EDN parsing, persistence, and a single-flight refresh to avoid duplicate requests.
Added jackInVersionFor helper in project-types and removed direct dependency on raw config for version lookup.
Activation now triggers a background refresh of missing versions after deps.clj is downloaded; this is non-blocking for startup.
Built-in default versions (used only if needed): nrepl 1.3.1, cider-nrepl 0.55.4, piggieback 0.6.0. (can be defined to be the latest before merge this PR)
Backwards compatible: existing pinned versions and workflows continue to work unchanged.

My Calva PR Checklist

I have:

netlify · 2025-10-24T22:35:22Z

✅ Deploy Preview for calva-docs ready!

Name	Link
🔨 Latest commit	`12ba8ba`
🔍 Latest deploy log	https://app.netlify.com/projects/calva-docs/deploys/6900b292a2d38d0008c94644
😎 Deploy Preview	https://deploy-preview-2960--calva-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

afucher · 2025-10-24T22:38:03Z

src/extension.ts

+  void depsClj
+    .downloadDepsClj(context.extensionPath)
+    .finally(() => {
+      void refreshJackInDependencyVersions();


Added here the code to get latest versions, because of the fallback to use deps.clj

afucher · 2025-10-24T22:38:51Z

src/nrepl/project-types.ts

-const NREPL_VERSION = () => getConfig().jackInDependencyVersions['nrepl'],
-  CIDER_NREPL_VERSION = () => getConfig().jackInDependencyVersions['cider-nrepl'],
-  PIGGIEBACK_VERSION = () => getConfig().jackInDependencyVersions['cider/piggieback'];
+const jackInVersionFor = (key: JackInDependencyKey) => getEffectiveJackInDependencyVersions()[key];


avoid get all config, and use directly the function that return the versions

afucher · 2025-10-24T22:44:57Z

src/nrepl/jack-in-dependency-versions.ts

+  const depsCljJarPath = getDepsCljJarPath();
+  if (depsCljJarPath) {
+    try {
+      const { stdout } = await execFileAsync('java', ['-jar', depsCljJarPath, ...args]);
+      const version = parseFindVersionsOutput(stdout);
+      if (version) {
+        return version;
+      }
+      errors.push(`deps.clj output missing version for ${library}`);
+    } catch (error) {
+      errors.push(`deps.clj failed: ${(error as Error).message}`);
+    }
+  } else {
+    errors.push('deps.clj.jar not available');
+  }
+
+  throw new Error(errors.join(' | '));
+}


Since Calva already download deps.clj jar, added this fallback to try to get the versions if the first approach fails.
I don't know if is needed to be honest, adds more complexity and I can't argue if when it fails by any reason using clojure cli, if this will be a good fallback.

I think this is great. So if someone is using Leiningen and do not have clojure they will still be running with latest jack-in dependencies.

afucher · 2025-10-24T22:45:39Z

src/nrepl/jack-in-dependency-versions.ts

+  'nrepl': '1.3.1',
+  'cider-nrepl': '0.55.4',
+  'cider/piggieback': '0.6.0',


These versions can be bumped to the latest (or any other specific version), before we merge the PR

Which are the latest now? I think we should use latest. And in the changelog we can put the versions used in Calva currently, so that someone who wants to configure those can easily find them.

@PEZ the latest are:

cider-nrepl = '0.58.0' cider/piggieback = '0.6.1' nrepl = '1.5.1'

in the changelog we can put the versions used in Calva currently

So, do you want to bump the default versions to the latest and add to the changelog which versions? The ones that were before the bump? or the latest?

PEZ · 2025-10-24T23:06:50Z

Thanks! This is so wonderful. And so wonderfully summarized. I will look closer tomorrow, late here now. =)

PEZ · 2025-10-24T23:08:29Z

The build is failing because of formatting btw. You can install the Prettier extension and it will run as a watcher if you are using the Build task. Then code will always be formatted on save.

package.json

src/nrepl/jack-in-dependency-versions.ts

Co-authored-by: Peter Strömberg <pez@pezius.com>

CHANGELOG.md

PEZ · 2025-10-27T21:23:22Z

Thanks. Looks fabulous!

I've suggested an update to the changelog entry.

Only other thing I think we want is that we log the checking to the console, also when things go well. Which versions we find and when global storage is updated. Good when developing on Calva and also for users to check when they report any problems.

We could also log latest versions to Calva says, together with the effective version, and from where the effective versions are decided (like “latest known by Calva”, “user configured override”, "Calva defaults fallback”).

I love the integration tests! ❤️

Co-authored-by: Peter Strömberg <pez@pezius.com>

afucher · 2025-10-28T12:19:46Z

@PEZ added the logs and messages to Calva says
Also, fixed the integration test because it was flaky

PEZ · 2025-10-28T13:39:19Z

Sweet!

check for latest version of dependencies

c4fcdd1

afucher commented Oct 24, 2025

View reviewed changes

PEZ reviewed Oct 25, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

PEZ reviewed Oct 25, 2025

View reviewed changes

src/nrepl/jack-in-dependency-versions.ts Outdated Show resolved Hide resolved

afucher and others added 7 commits October 27, 2025 11:17

rollback to define default versions in package.json

946d32b

bump default versions to latest

0e1e42c

prettier

009c717

upd docs

cc390ec

CHANGELOG

b1cdf4a

Update package.json

eb7ab82

Co-authored-by: Peter Strömberg <pez@pezius.com>

create integration test

2279939

afucher marked this pull request as ready for review October 27, 2025 19:32

PEZ reviewed Oct 27, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

afucher and others added 4 commits October 28, 2025 07:48

Update CHANGELOG.md

82e477f

Co-authored-by: Peter Strömberg <pez@pezius.com>

add logs and info to Calva says

1c6c6db

fix flaky test

cf4d211

prettier fix

12ba8ba

PEZ merged commit 5489a94 into BetterThanTomorrow:dev Oct 28, 2025
5 checks passed

Uh oh!

Uh oh!

[wip] feat: uses latest version of depencies for jack-in #2960

[wip] feat: uses latest version of depencies for jack-in #2960

Conversation

afucher commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What has changed?

My Calva PR Checklist

Uh oh!

netlify bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for calva-docs ready!

Uh oh!

afucher Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

afucher Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

afucher Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

PEZ Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

afucher Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PEZ Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

afucher Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PEZ commented Oct 24, 2025

Uh oh!

PEZ commented Oct 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PEZ commented Oct 27, 2025

Uh oh!

afucher commented Oct 28, 2025

Uh oh!

PEZ commented Oct 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

afucher commented Oct 24, 2025 •

edited

Loading

netlify bot commented Oct 24, 2025 •

edited

Loading

afucher Oct 24, 2025 •

edited

Loading

afucher Oct 27, 2025 •

edited

Loading