London | 25-SDC-July | Ali Qassab | Module-Legacy-Code | Sprint 1 | Hashtag link doesn't work correctly #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliQassab
added
the
Needs Review
mjpeet
reviewed
Oct 26, 2025
| return text.replace( | ||
| /\B#[^#]+/g, | ||
| /\B#\w+/g, | ||
| // /\B#[^#]+/g, |
There was a problem hiding this comment.
usually we don't leave comments like this in the code (this is why git is there - to track changes)
| if (!text) return text; | ||
| return text.replace( | ||
| /\B#[^#]+/g, | ||
| /\B#\w+/g, |
There was a problem hiding this comment.
great work for fixing this bug! The solution is precise, well-reasoned, and demonstrates solid understanding of regex patterns and how hashtags should behave.
mjpeet
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Fix Hashtag Parsing Issue
Problem: Hashtag links with spaces or punctuation were creating broken URLs and showing empty pages.
Example: Clicking
#SwizBizin "Let's get some #SwizBiz love!!" created URL/hashtag/SwizBiz love!!which showed no blooms.Solution: Updated hashtag regex from
/\B#[^#]+/gto/\B#\w+/gto only capture valid hashtag characters (letters, numbers, underscores).Result: All
#SwizBizhashtags now correctly navigate to/hashtag/SwizBizand show all related blooms.Files Changed:
front-end/components/bloom.mjs- Updated_formatHashtags()function