Feature/steps #11
Open
Feature/steps #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rendering a series of steps.
…Content and Step Label.
KonradSzwarc
requested changes
Aug 20, 2019
| }); | ||
|
|
||
| export const StepContent = (props: StepContentProps) => { | ||
| const StepContent = |
Member
There was a problem hiding this comment.
Tę logikę lepiej wyrzuć do jakiejś funkcji, to łatwiej będzie to czytać. Najlepiej zrobić switch
| let updatedChildren = React.Children.map(child.props.children as ReactElement[], (innerChild, index) => { | ||
| if (index === 0) { | ||
| return React.cloneElement(innerChild as ReactElement, { state: state, children: number }); | ||
| } else { |
Member
There was a problem hiding this comment.
Skoro w if powyżej znajduje się return, to else nie jest konieczne. Wystarczy, że zostawisz samą jego zawartość.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Komponent jest funkcjonalny, wymaga jeszcze drobnych poprawek (np. nie można zmienić rozmiaru pojedynczego stepa). Steps, które mają określony
state, mają zaaplikowane defaultowe kolory. Jeślistatenie jest określony, można im dowolnie zmieniać kolor tła i kolor fontu. Teraz ikony można zmieniać dowolnie, ale mogę dodać defaultowe ikony dlastate = successistate = error.