Skip to content

Add full name property to Collection #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add full name property to Collection #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CollectionManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,16 @@ object CollectionManager {
return count
}

@Throws(Exception::class)
fun fullName(
collectionName: String,
scopeName: String,
databaseName: String
): String {
val col = this.getCollection(collectionName, scopeName, databaseName)
return col?.fullName ?: throw Exception("Collection not found: $collectionName in scope: $scopeName")
Copy link

@gemini-code-assist gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better error handling and debugging, consider throwing a more specific exception and providing a more detailed error message.

  • Exception Type: Instead of the generic Exception, throwing a more specific one like IllegalArgumentException or NoSuchElementException allows callers to handle this specific error case more cleanly.
  • Error Message: The current error message is missing the databaseName, which is crucial for identifying which database the collection was not found in. Including it will make debugging easier.
Suggested change
return col?.fullName ?: throw Exception("Collection not found: $collectionName in scope: $scopeName")
return col?.fullName ?: throw IllegalArgumentException("Collection '$collectionName' not found in scope '$scopeName' of database '$databaseName'")

}

@Throws(Exception::class)
fun getBlobContent(key: String,
documentId: String,
Expand Down