- 
                Notifications
    
You must be signed in to change notification settings  - Fork 315
 
Handle incomplete crash reports #9875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
           🎯 Code Coverage 🔗 Commit SHA: 1e66113 | Docs | Datadog PR Page | Was this helpful? Give us feedback!  | 
    
          BenchmarksStartupParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~1e6611316c, baseline=1.55.0-SNAPSHOT~949ee8ce67
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.035 s) : 0, 1034902
Total [baseline] (8.697 s) : 0, 8696635
Agent [candidate] (1.032 s) : 0, 1032433
Total [candidate] (8.652 s) : 0, 8651563
section iast
Agent [baseline] (1.169 s) : 0, 1169051
Total [baseline] (9.376 s) : 0, 9375969
Agent [candidate] (1.162 s) : 0, 1162286
Total [candidate] (9.383 s) : 0, 9383130
    
 
 
 
 gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~1e6611316c, baseline=1.55.0-SNAPSHOT~949ee8ce67
    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (707.048 ms) : 0, 707048
BytebuddyAgent [candidate] (703.129 ms) : 0, 703129
GlobalTracer [baseline] (244.745 ms) : 0, 244745
GlobalTracer [candidate] (245.826 ms) : 0, 245826
AppSec [baseline] (32.279 ms) : 0, 32279
AppSec [candidate] (32.648 ms) : 0, 32648
Debugger [baseline] (6.357 ms) : 0, 6357
Debugger [candidate] (6.456 ms) : 0, 6456
Remote Config [baseline] (679.923 µs) : 0, 680
Remote Config [candidate] (678.084 µs) : 0, 678
Telemetry [baseline] (15.314 ms) : 0, 15314
Telemetry [candidate] (14.427 ms) : 0, 14427
Flare Poller [baseline] (5.731 ms) : 0, 5731
Flare Poller [candidate] (6.651 ms) : 0, 6651
section iast
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (829.854 ms) : 0, 829854
BytebuddyAgent [candidate] (824.705 ms) : 0, 824705
GlobalTracer [baseline] (235.13 ms) : 0, 235130
GlobalTracer [candidate] (234.15 ms) : 0, 234150
IAST [baseline] (31.826 ms) : 0, 31826
IAST [candidate] (32.486 ms) : 0, 32486
AppSec [baseline] (29.926 ms) : 0, 29926
AppSec [candidate] (28.87 ms) : 0, 28870
Debugger [baseline] (6.141 ms) : 0, 6141
Debugger [candidate] (6.128 ms) : 0, 6128
Remote Config [baseline] (597.702 µs) : 0, 598
Remote Config [candidate] (606.173 µs) : 0, 606
Telemetry [baseline] (8.533 ms) : 0, 8533
Telemetry [candidate] (8.482 ms) : 0, 8482
Flare Poller [baseline] (4.058 ms) : 0, 4058
Flare Poller [candidate] (4.116 ms) : 0, 4116
    Startup time reports for petclinicgantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~1e6611316c, baseline=1.55.0-SNAPSHOT~949ee8ce67
    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1029621
Total [baseline] (10.843 s) : 0, 10843330
Agent [candidate] (1.046 s) : 0, 1046190
Total [candidate] (10.818 s) : 0, 10818255
section appsec
Agent [baseline] (1.203 s) : 0, 1203311
Total [baseline] (10.968 s) : 0, 10967553
Agent [candidate] (1.206 s) : 0, 1205935
Total [candidate] (10.985 s) : 0, 10984562
section iast
Agent [baseline] (1.17 s) : 0, 1169691
Total [baseline] (11.234 s) : 0, 11234059
Agent [candidate] (1.17 s) : 0, 1170415
Total [candidate] (11.152 s) : 0, 11151771
section profiling
Agent [baseline] (1.181 s) : 0, 1180645
Total [baseline] (10.876 s) : 0, 10876090
Agent [candidate] (1.177 s) : 0, 1177335
Total [candidate] (10.87 s) : 0, 10870178
    
 
 
 
 gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~1e6611316c, baseline=1.55.0-SNAPSHOT~949ee8ce67
    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (701.868 ms) : 0, 701868
BytebuddyAgent [candidate] (713.923 ms) : 0, 713923
GlobalTracer [baseline] (244.985 ms) : 0, 244985
GlobalTracer [candidate] (248.272 ms) : 0, 248272
AppSec [baseline] (32.22 ms) : 0, 32220
AppSec [candidate] (32.816 ms) : 0, 32816
Debugger [baseline] (6.401 ms) : 0, 6401
Debugger [candidate] (6.499 ms) : 0, 6499
Remote Config [baseline] (687.23 µs) : 0, 687
Remote Config [candidate] (691.665 µs) : 0, 692
Telemetry [baseline] (13.054 ms) : 0, 13054
Telemetry [candidate] (13.938 ms) : 0, 13938
Flare Poller [baseline] (7.777 ms) : 0, 7777
Flare Poller [candidate] (7.208 ms) : 0, 7208
section appsec
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (726.566 ms) : 0, 726566
BytebuddyAgent [candidate] (727.632 ms) : 0, 727632
GlobalTracer [baseline] (236.049 ms) : 0, 236049
GlobalTracer [candidate] (236.657 ms) : 0, 236657
IAST [baseline] (25.046 ms) : 0, 25046
IAST [candidate] (25.058 ms) : 0, 25058
AppSec [baseline] (174.279 ms) : 0, 174279
AppSec [candidate] (174.975 ms) : 0, 174975
Debugger [baseline] (5.902 ms) : 0, 5902
Debugger [candidate] (5.999 ms) : 0, 5999
Remote Config [baseline] (624.943 µs) : 0, 625
Remote Config [candidate] (630.821 µs) : 0, 631
Telemetry [baseline] (8.409 ms) : 0, 8409
Telemetry [candidate] (8.506 ms) : 0, 8506
Flare Poller [baseline] (3.854 ms) : 0, 3854
Flare Poller [candidate] (3.969 ms) : 0, 3969
section iast
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (829.759 ms) : 0, 829759
BytebuddyAgent [candidate] (831.46 ms) : 0, 831460
GlobalTracer [baseline] (234.798 ms) : 0, 234798
GlobalTracer [candidate] (235.067 ms) : 0, 235067
IAST [baseline] (33.099 ms) : 0, 33099
IAST [candidate] (32.633 ms) : 0, 32633
AppSec [baseline] (29.246 ms) : 0, 29246
AppSec [candidate] (29.01 ms) : 0, 29010
Debugger [baseline] (6.231 ms) : 0, 6231
Debugger [candidate] (6.098 ms) : 0, 6098
Remote Config [baseline] (627.369 µs) : 0, 627
Remote Config [candidate] (598.918 µs) : 0, 599
Telemetry [baseline] (8.719 ms) : 0, 8719
Telemetry [candidate] (8.441 ms) : 0, 8441
Flare Poller [baseline] (4.197 ms) : 0, 4197
Flare Poller [candidate] (4.142 ms) : 0, 4142
section profiling
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (731.93 ms) : 0, 731930
BytebuddyAgent [candidate] (730.061 ms) : 0, 730061
GlobalTracer [baseline] (221.939 ms) : 0, 221939
GlobalTracer [candidate] (220.839 ms) : 0, 220839
AppSec [baseline] (33.268 ms) : 0, 33268
AppSec [candidate] (32.29 ms) : 0, 32290
Debugger [baseline] (9.822 ms) : 0, 9822
Debugger [candidate] (11.443 ms) : 0, 11443
Remote Config [baseline] (1.408 ms) : 0, 1408
Remote Config [candidate] (701.074 µs) : 0, 701
Telemetry [baseline] (11.428 ms) : 0, 11428
Telemetry [candidate] (11.385 ms) : 0, 11385
Flare Poller [baseline] (4.111 ms) : 0, 4111
Flare Poller [candidate] (4.099 ms) : 0, 4099
ProfilingAgent [baseline] (109.408 ms) : 0, 109408
ProfilingAgent [candidate] (109.308 ms) : 0, 109308
Profiling [baseline] (110.065 ms) : 0, 110065
Profiling [candidate] (109.926 ms) : 0, 109926
    LoadParameters
 See matching parameters
 SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics. 
 Request duration reports for petclinicgantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~1e6611316c, baseline=1.55.0-SNAPSHOT~949ee8ce67
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.981 ms) : 18789, 19174
.   : milestone, 18981,
appsec (19.315 ms) : 19116, 19514
.   : milestone, 19315,
code_origins (19.57 ms) : 19376, 19763
.   : milestone, 19570,
iast (17.795 ms) : 17617, 17972
.   : milestone, 17795,
profiling (19.492 ms) : 19295, 19689
.   : milestone, 19492,
tracing (18.299 ms) : 18114, 18484
.   : milestone, 18299,
section candidate
no_agent (18.279 ms) : 18094, 18465
.   : milestone, 18279,
appsec (19.918 ms) : 19715, 20120
.   : milestone, 19918,
code_origins (19.632 ms) : 19439, 19826
.   : milestone, 19632,
iast (19.514 ms) : 19317, 19712
.   : milestone, 19514,
profiling (20.56 ms) : 20355, 20766
.   : milestone, 20560,
tracing (18.494 ms) : 18304, 18683
.   : milestone, 18494,
    
 
 
 
 Request duration reports for insecure-bankgantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~1e6611316c, baseline=1.55.0-SNAPSHOT~949ee8ce67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.202 ms) : 1190, 1213
.   : milestone, 1202,
iast (3.211 ms) : 3164, 3257
.   : milestone, 3211,
iast_FULL (5.709 ms) : 5652, 5765
.   : milestone, 5709,
iast_GLOBAL (3.643 ms) : 3579, 3706
.   : milestone, 3643,
profiling (2.049 ms) : 2032, 2066
.   : milestone, 2049,
tracing (1.77 ms) : 1756, 1784
.   : milestone, 1770,
section candidate
no_agent (1.205 ms) : 1193, 1216
.   : milestone, 1205,
iast (3.2 ms) : 3161, 3240
.   : milestone, 3200,
iast_FULL (5.762 ms) : 5705, 5820
.   : milestone, 5762,
iast_GLOBAL (3.642 ms) : 3589, 3696
.   : milestone, 3642,
profiling (2.181 ms) : 2160, 2202
.   : milestone, 2181,
tracing (1.751 ms) : 1737, 1766
.   : milestone, 1751,
    
 
 
 
 DacapoParameters
 See matching parameters
 SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~1e6611316c, baseline=1.55.0-SNAPSHOT~949ee8ce67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1499
.   : milestone, 1487,
appsec (3.676 ms) : 3463, 3889
.   : milestone, 3676,
iast (2.223 ms) : 2159, 2287
.   : milestone, 2223,
iast_GLOBAL (2.254 ms) : 2191, 2318
.   : milestone, 2254,
profiling (2.077 ms) : 2024, 2129
.   : milestone, 2077,
tracing (2.049 ms) : 1999, 2099
.   : milestone, 2049,
section candidate
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (3.666 ms) : 3453, 3879
.   : milestone, 3666,
iast (2.218 ms) : 2155, 2282
.   : milestone, 2218,
iast_GLOBAL (2.266 ms) : 2203, 2330
.   : milestone, 2266,
profiling (2.093 ms) : 2040, 2146
.   : milestone, 2093,
tracing (2.037 ms) : 1987, 2086
.   : milestone, 2037,
    
 
 
 
 Execution time for biojavagantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~1e6611316c, baseline=1.55.0-SNAPSHOT~949ee8ce67
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.478 s) : 15478000, 15478000
.   : milestone, 15478000,
appsec (15.095 s) : 15095000, 15095000
.   : milestone, 15095000,
iast (18.476 s) : 18476000, 18476000
.   : milestone, 18476000,
iast_GLOBAL (18.151 s) : 18151000, 18151000
.   : milestone, 18151000,
profiling (15.11 s) : 15110000, 15110000
.   : milestone, 15110000,
tracing (15.579 s) : 15579000, 15579000
.   : milestone, 15579000,
section candidate
no_agent (15.284 s) : 15284000, 15284000
.   : milestone, 15284000,
appsec (15.014 s) : 15014000, 15014000
.   : milestone, 15014000,
iast (18.662 s) : 18662000, 18662000
.   : milestone, 18662000,
iast_GLOBAL (17.842 s) : 17842000, 17842000
.   : milestone, 17842000,
profiling (15.208 s) : 15208000, 15208000
.   : milestone, 15208000,
tracing (15.205 s) : 15205000, 15205000
.   : milestone, 15205000,
    
 
 
 
  | 
    
b70aaa5    to
    27abfdb      
    Compare
  
    
What Does This Do
Give a chance to send report even if incomplete to the telemetry.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]