Skip to content

Conversation

@wesleyboar
Copy link
Collaborator

@wesleyboar wesleyboar commented Dec 18, 2024

@wesleyboar wesleyboar marked this pull request as draft December 18, 2024 01:13
Copy link
Collaborator Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for reviewers.

Comment on lines -116 to -123
# the following have been moved to the user guide. we need to remove these files from the directory in use cases, but doing so would break `{% include-markdown '../usecases/haan/usecase` in `user-guide/docs/tools/visualization.md`
# - Basic Image Browsing and Mapping: usecases/haan/usecase.md
# - Grouping and Tagging Image Files: usecases/haan/usecase-2.md
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved via #105.

Comment on lines -105 to -116
# - Use Cases Flat:
# - Overview: usecases/overview.md
# - Data Analytics: usecases/dataanalyticsusecases.md
# - GeoHazard: usecases/geohazardusecases.md
# - Seismic: usecases/seismicusecases.md
# - Wind and Storm Surge: usecases/windstormsurgeusecases.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I deleted these files, I think I need not archive old links to them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed <a> to <article> and removing href.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to update this because it was all about files I deleted.

/* https://github.com/DesignSafe-CI/DS-User-Guide/blob/df64c11/user-guide/docs/usecases/overview.md?plain=1#L34-L37 */
/* https://github.com/TACC/Core-Styles/blob/v2.27.0/src/lib/_imports/components/c-card--docs.css#L23-L29 */
[class*=card--]:hover :is( .h1, .h2, .h3, .h4, .h5, .h6 ) {
a[class*=card--]:hover :is( .h1, .h2, .h3, .h4, .h5, .h6 ) {
Copy link
Collaborator Author

@wesleyboar wesleyboar Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed bug that only showed when I changed cards to not be links.

@wesleyboar wesleyboar marked this pull request as ready for review December 18, 2024 01:23
@wesleyboar
Copy link
Collaborator Author

@silviamazzoni, do you still want this change? See video in "UI" section of description.

@silviamazzoni
Copy link
Collaborator

I honestly can't remember what this is about....

@wesleyboar wesleyboar added the paused Started but not actively in progress label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

paused Started but not actively in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants