Skip to content

Conversation

@nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Nov 7, 2025

Description

  • Allow non-string values for censor elements (compare string-string via conversions)

Closes #76

Testing

  • Add unit tests to test three times of censor elements with non-string values, via body content

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested review from a team as code owners November 7, 2025 08:18
@nwithan8
Copy link
Contributor Author

nwithan8 commented Nov 7, 2025

Unit tests have been modified, rather than hitting like Reddit JSON and XML feeds, use snapshots of the r/ProgrammerHumor JSON and RSS feeds stored in this repo. #78 will need to be merged first for the unit tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyCensorElement is not taken into account if the value is not a string

2 participants