autoclean: don't increment num_cleaned when record wasn't even a candidate #8651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idate. For example, `autoclean-once failedforwards` would count every non-failed forwards as "uncleaned". This is both technically correct and completely useless. Changelog-Fixed: JSON-RPC: `autoclean-once` returns "uncleaned" number reflecting number of candidates which were too new to be cleaned, not all records we didn't delete. Fixes: ElementsProject#8632 Reported-by: @grubles and several other sharp-eyed users. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
autoclean-fix-uncleaned
branch
from
f50c9b9 to
e24ec30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
autoclean-once failedforwardswould count every non-failed forwards as "uncleaned".This is both technically correct and completely useless.
Fixes: #8632
Reported-by: @grubles and several other sharp-eyed users.
From the documentation:
"NOTE: until v25.12, the
uncleanedfield contained all entries not removed (e.g. infailedforwardsit counted all forwards, not just failed ones). This was an interface only an engineer could love, so it was fixed."