Fix error message for incorrect subtype in encoder.write()
#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump fork to V3
TrentHouliston
approved these changes
Jan 29, 2025
Collaborator
|
If we're making the subtype required, change the type in But I think it would be better to keep it optional from the outside and default it to zero before passing it to C++. Edit: looks like your changes do make it behave as described above. We may just need a test with subtype excluded and subtype set to undefined - this could be done with extra packets in the roundtrip test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error message that is shown when parsing a
NbsWritePackettype with asubtypefield that is the wrong type or explicitly set as undefined.It would previously print the error message "invalid type for argument `packet`: A number was expected". These changes make it now print "invalid type for argument `packet`: expected `subtype` to be a number".