feat: optional support for react-native-nitro-sound #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
isekovanic
reviewed
Oct 31, 2025
|
|
||
| export enum AVModeIOSOption { | ||
| // TODO: Remove this enum when audio recorder player is removed completely | ||
| export enum AVModeIOSOptionAudioRecorderPlayer { |
There was a problem hiding this comment.
This is breaking - please keep the naming the same (and we can change it in the next major whenever we remove the other library).
isekovanic
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the PR is to add optional support for the package
react-native-nitro-soundas the previous alternativereact-native-audio-recorder-playeris completely deprecated and there are customer reports of users facing issues with the package.We should plan to remove the usage of
react-native-audio-recorder-playerin the next major release.This fixes #3217.