fix: add shell option to npm spawn on Windows #1815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Windows-specific EINVAL error when spawning npm install commands.
Problem
On Windows, the run_npm_install function in Kernel.js was failing with
spawn EINVALerror because it was missing theshell: trueoption when spawningnpm.cmd.Solution
shell: trueto spawn options in run_npm_install functionProcessService.jsand LocalTerminalService.js)Changes
shell: trueto spawn optionsFixes
Why Windows Needs shell: true:
Proof from Codebase:
Other spawn calls in the same codebase already use shell: true:
Testing
Type of Change