Update files.js and deleteUser to use ll_read #1839
+29
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GitHub is erroneously showing repeated changes from the last PR. I need to investigate why this is happening. update: that was worth investigating; this branch had the wrong base |
Accessing the storage object directly duplicates effort of locating the correct filesystem provider based on the mountpoint of the file with the contents being requested; an effort that file.js did not perform which made it incompatible with filesystem mountpoints. This change has been made to make it easier to move filesystem type implementations to extensions, because accessing storage directly will not be supported after puterfs is an extension.
The previous implementation of deleteUser was hard-coded to use the PuterFSProvider file system type's storage implementation specifically, even if a different filesystem type is mounted as root or for a particular user. This change was tested by creating a user, adding some fsentries, and then deleting that user. The following classes of filesystem entry were checked: - [x] user created directory (with contents) - [x] directory fsentry was deleted - [x] user created directory (empty) - [x] directory fsentry was deleted - [x] immutable directory - [x] directory fsentry was deleted - [x] user created file - [x] file fsentry was deleted - [x] file storage was deleted - [x] user created file in trash - [x] file fsentry was deleted - [x] file storage was deleted
The PR I merged before putting this one up had my changes to api.d.ts which I thought where on this branch - turns out I only thought that because this branch had that one as a parent. However #1818 has a simplification that this change overwrites. I'd like to keep this simplification so this commit is restoring it.
KernelDeimos
force-pushed
the
eric/25AR0
branch
from
a109934 to
a664d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.