Skip to content

Conversation

@branchvincent
Copy link
Member

libsigrok: migrate to python@3.14

Copilot AI review requested due to automatic review settings October 27, 2025 00:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the libsigrok formula from Python 3.13 to Python 3.14 by updating the dependency specification and the python3 helper method.

  • Updated dependency from python@3.13 to python@3.14
  • Updated the python3 method to return "python3.14" instead of "python3.13"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Oct 27, 2025
@branchvincent
Copy link
Member Author

  ../../../bindings/python/sigrok/core/../../../swig/classes.i:51: Warning 330: Template forward class 'enable_shared_from_this< Context >' cannot be used to instantiate a full template class with name 'ContextShared'.
  sigrok/core/classes_wrap.cpp: In function ‘int SWIG_mod_exec(PyObject*)’:
  sigrok/core/classes_wrap.cpp:62265:12: error: cannot convert ‘std::nullptr_t’ to ‘int’ in return
  62265 |     return nullptr;
        |            ^~~~~~~
  error: command '/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/linux/super/g++-12' failed with exit code 1
  make[1]: *** [Makefile:5290: bindings/python/timestamp] Error 1
  make: *** [Makefile:1992: all] Error 2

@branchvincent branchvincent marked this pull request as draft October 27, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Python use is a significant feature of the PR or issue python-3.14-migration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant