Skip to content

Conversation

@araujof
Copy link
Member

@araujof araujof commented Oct 30, 2025

Summary

Fixed the nginx Docker build issue by removing the nginx -t configuration test from the Dockerfile. This is the standard approach for containerized nginx deployments where:

  1. Build time: The upstream hostname (gateway:4444) doesn't exist yet - it's only created when docker-compose brings up the network
  2. Runtime: When the container starts, nginx will still validate the configuration and fail immediately if there are syntax errors
  3. Best practice: Configuration validation at runtime is acceptable for Docker deployments since the container won't start successfully if the config is invalid

Changes

  • nginx/Dockerfile:21-23: Removed RUN nginx -t and added an explanatory comment
  • Nginx will still perform the same validation when the container starts, when it can resolve the gateway:4444 hostname correctly

This is a common pattern in production nginx container deployments where upstream services are defined in docker-compose or Kubernetes networks.

Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
@araujof araujof added this to the Release 0.9.0 milestone Oct 30, 2025
@araujof araujof self-assigned this Oct 30, 2025
@araujof araujof requested a review from crivetimihai as a code owner October 30, 2025 02:53
@araujof araujof added the bug Something isn't working label Oct 30, 2025
@crivetimihai
Copy link
Member

Already fixed in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants