[Fix] refactor evaluation dataloader to episodeloader (WIP) #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Gariscat
commented
Nov 5, 2025
Gariscat
commented
- [remove-projects-folder]
- [renamed 'EvalDatasetCfg' to 'EpisodeCfg']
- [refactor 'load_data' func & rename 'self.dataloader' to 'self.episode_iterator']
kew6688
changed the title
kew6688
reviewed
Nov 7, 2025
| @@ -1,5 +1,5 @@ | |||
| #!/bin/bash | |||
|
|
|||
| unset https_proxy http_proxy | |||
| EnvCfg, | ||
| EvalCfg, | ||
| EvalDatasetCfg, | ||
| EpisodeCfg, |
Collaborator
There was a problem hiding this comment.
change back to EvalDatasetCfg
Collaborator
There was a problem hiding this comment.
shouldn't remove submodule
|
|
||
|
|
||
| class EvalDatasetCfg(BaseModel): | ||
| class EpisodeCfg(BaseModel): |
Collaborator
There was a problem hiding this comment.
still should be DatasetCfg
| for path in path_list: | ||
| trajectory_id = path['trajectory_id'] | ||
| if revise_data: | ||
| if trajectory_id in skip_list: |
Collaborator
There was a problem hiding this comment.
This skip list is not for all dataset type. Move this part out from the base
| if revise_data: | ||
| if trajectory_id in skip_list: | ||
| continue | ||
| path = revise_one_data(path) |
Collaborator
There was a problem hiding this comment.
Move this part out from the base too
| scenes.sort() | ||
| # Rotation: quaternion [w, x, y, z] → transformed as [-z, x, y, -w] (90° around Z) | ||
| r1, r2, r3, r4 = start_rotation # original: [w, x, y, z] ? | ||
| new_rot = [-r4, r1, r3, -r2] # adjust according to your transform_rotation_z_90degrees impl |
Collaborator
There was a problem hiding this comment.
need to apply transform_rotation_z_90degrees()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.