-
-
Notifications
You must be signed in to change notification settings - Fork 252
feat: add slip44 identifier for added networks #7034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
What is the current state and why does it need to change?
Currently, there is no centralized way to resolve SLIP-44 coin types from EVM chain IDs. SLIP-44 coin types are essential for generating CAIP-19 asset identifiers, which are used for representing native currencies across different blockchains in a standardized format.
What is the solution and how does it work?
This PR introduces a new
ChainServicemodule that provides two main functions:getSlip44ByChainId(chainId: number): Resolves the SLIP-44 coin type for a given EVM chain ID@metamask/slip44datasetCOMMON_SYMBOL_DEFAULTS) for popular chainsgetNativeCaip19(chainId: number): Generates CAIP-19 asset identifiers for native currencieseip155:{chainId}/slip44:{coinType}Key implementation details:
References
Checklist
@paramand@returns