Skip to content

Conversation

@hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Nov 3, 2025

Explanation

Used the error reporting service to capture exceptions around account creation.

References

n/a

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Integrates ErrorReportingService to capture exceptions during multichain account creation, alignment, and discovery, adds a createSentryError utility, updates messenger/types, and adjusts tests and peer deps.

  • multichain-account-service:
    • Error reporting integration:
      • In MultichainAccountWallet and MultichainAccountGroup, wrap provider failures in createSentryError and call ErrorReportingService:captureException during createAccounts (EVM and non‑EVM), alignAccounts, and discoverAccounts.
    • Utilities:
      • Add utils#createSentryError to attach cause and context to errors.
    • Messaging/Types:
      • Extend MultichainAccountServiceMessenger allowed actions to include ErrorReportingService:captureException; update test messenger delegation.
    • Tests:
      • Update unit tests to register/mock ErrorReportingService:captureException and assert calls on provider failures.
    • Changelog/Deps:
      • Update CHANGELOG.md with BREAKING note; add @metamask/error-reporting-service as a peer dependency (and devDependency).

Written by Cursor Bugbot for commit 19411d9. This will update automatically on new commits. Configure here.

@hmalik88 hmalik88 requested review from a team as code owners November 3, 2025 15:50
fabiobozzo
fabiobozzo previously approved these changes Nov 4, 2025
Copy link
Contributor

@fabiobozzo fabiobozzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hmalik88 hmalik88 changed the title feat(multichain-account-service): add error reporting around account creation **BREAKING** feat(multichain-account-service): add error reporting around account creation Nov 5, 2025
@ccharly ccharly changed the title **BREAKING** feat(multichain-account-service): add error reporting around account creation feat(multichain-account-service)!: add error reporting around account creation Nov 5, 2025
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hmalik88 hmalik88 merged commit 9255484 into main Nov 6, 2025
267 checks passed
@hmalik88 hmalik88 deleted the hm/add-error-reporting branch November 6, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants