-
-
Notifications
You must be signed in to change notification settings - Fork 252
feat(multichain-account-service)!: add error reporting around account creation #7044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+198
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobozzo
reviewed
Nov 4, 2025
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
fabiobozzo
previously approved these changes
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ccharly
requested changes
Nov 4, 2025
ccharly
reviewed
Nov 5, 2025
ccharly
reviewed
Nov 6, 2025
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountGroup.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.test.ts
Outdated
Show resolved
Hide resolved
ccharly
approved these changes
Nov 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Used the error reporting service to capture exceptions around account creation.
References
n/a
Checklist
Note
Integrates
ErrorReportingServiceto capture exceptions during multichain account creation, alignment, and discovery, adds acreateSentryErrorutility, updates messenger/types, and adjusts tests and peer deps.MultichainAccountWalletandMultichainAccountGroup, wrap provider failures increateSentryErrorand callErrorReportingService:captureExceptionduringcreateAccounts(EVM and non‑EVM),alignAccounts, anddiscoverAccounts.utils#createSentryErrorto attachcauseandcontextto errors.MultichainAccountServiceMessengerallowed actions to includeErrorReportingService:captureException; update test messenger delegation.ErrorReportingService:captureExceptionand assert calls on provider failures.CHANGELOG.mdwith BREAKING note; add@metamask/error-reporting-serviceas a peer dependency (and devDependency).Written by Cursor Bugbot for commit 19411d9. This will update automatically on new commits. Configure here.