Skip to content

Nixpkgs committers: Refer to new repo and switch to PR nominations #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Nixpkgs committers: Refer to new repo and switch to PR nominations #179

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a7147d
Refer to nixpkgs committers repository for member listing
infinisil Sep 27, 2025
fb8b8bd
Switch to PR-based nixpkgs committer nomination process
infinisil Sep 27, 2025
5d959ff
Document nixpkgs committers github team
infinisil Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/nixpkgs-committers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Nixpkgs committers

There are over 200 Nixpkgs committers with access to merge any PR.
To become a Nixpkgs committer, you can apply [in this issue](https://github.com/NixOS/nixpkgs/issues/321665).
There are [200 Nixpkgs committers](https://github.com/NixOS/nixpkgs-committers/tree/main/members) with access to merge any PR.
To become a Nixpkgs committer, you can nominate by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's better to use "nominate" instead of "apply", but as-is the phrasing feels off.

I think for "nominate" to feel natural, you have to specify who is being nominated.

Suggested change
To become a Nixpkgs committer, you can nominate by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations).
To become a Nixpkgs committer, you can nominate yourself by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations).

This wrongly implies you can't nominate others. That's no worse than the existing wording, but maybe we can take this opportunity to improve on it?

This feels a bit wordy though and I'm currently lacking inspiration:

Suggested change
To become a Nixpkgs committer, you can nominate by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations).
You can nominate yourself — or another contributor — to become a Nixpkgs committer.
This should be done by following [these instructions](https://github.com/NixOS/nixpkgs-committers?tab=readme-ov-file#nominations).


The [Nixpkgs committer delegation team](#team) is given the responsibility and authority of changing the list of [Nixpkgs committers](https://github.com/orgs/NixOS/teams/nixpkgs-committers).

Expand All @@ -13,7 +13,7 @@ Nixpkgs committer delegation team consists of these people:
- [@jtojnar](https://github.com/jtojnar) ([Matrix](https://matrix.to/#/@jtojnar:matrix.org), [Discourse](https://discourse.nixos.org/u/jtojnar))
- [@winterqt](https://github.com/winterqt) ([Matrix](https://matrix.to/#/@winter:catgirl.cloud), [Discourse](https://discourse.nixos.org/u/winter))

They can be contacted either individually, or through a [group message on Discourse](https://discourse.nixos.org/g/nixpkgs-nominations).
They can be contacted either individually, through a [group message on Discourse](https://discourse.nixos.org/g/nixpkgs-nominations), or by pinging the GitHub team [@NixOS/commit-bit-delegation](https://github.com/orgs/NixOS/teams/commit-bit-delegation/).

## Process
- The process must be publicly documented (this document)
Expand Down