Cleanup for Vista related code in the compile time. Cleanup copy-past from Windows SDK. It's probably fix for issues related to the Windows 7. Improve compilation time. #2068
+328
−307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he compile time because we don't support Vista.
#define VC_EXTRALEAN #define NOMINMAX #define WIN32_LEAN_AND_MEAN (if it's possible)
_WIN32_WINNT is set for Windows 7. NTDDI_VERSION is set for Windows 8. _WIN32_IE is set for IE11. _WIN32_WINDOWS define is removed because it's usefulness.
|
This does not fix the classic theme so far:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixed #2055 and may'be other Windows 7 related issues.
_WIN32_WINNT is set for Windows 7.
NTDDI_VERSION is set for Windows 8.
_WIN32_IE is set for IE11.
_WIN32_WINDOWS define is removed because it's usefulness.
#define _ATL_ALL_WARNINGS
#define VC_EXTRALEAN
#define NOMINMAX
#define WIN32_LEAN_AND_MEAN (if it's possible)
Fix copy-pasted code from SDK and disable code for Windows Vista in the compile time because we don't support Vista.