Skip to content

Stellar vault #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 4, 2025
Merged

Stellar vault #61

merged 9 commits into from
Nov 4, 2025

Conversation

@ozgunozerk
Copy link
Collaborator

@ozgunozerk ozgunozerk commented Oct 21, 2025

No description provided.

@netlify
Copy link

netlify bot commented Oct 21, 2025 •
edited
Loading

❌ Deploy Preview for openzeppelin-docs-v2 failed. Why did it fail? →

Name Link
🔨 Latest commit 9dd2daa
🔍 Latest deploy log https://app.netlify.com/projects/openzeppelin-docs-v2/deploys/690a12a83185650008a0ec70

@ozgunozerk ozgunozerk marked this pull request as ready for review November 3, 2025 13:32
@ozgunozerk ozgunozerk requested a review from brozorec November 3, 2025 13:32
@ozgunozerk
Copy link
Collaborator Author

ozgunozerk commented Nov 3, 2025 •
edited
Loading

@brozorec I'll resolve the conflicts later, i requested review only on the content of the main document to save time 👍

@ozgunozerk ozgunozerk self-assigned this Nov 4, 2025
brozorec
brozorec requested changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@brozorec brozorec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add "Vault" in the navigation
  2. You're using "Vault Token", but isn't it more commonly referred as "Token Vault" 🤔
  3. Review links as it's not in "extensions" any more
  4. Should we also add a basic "Usage" section at the end where showing how to implement it?

@ozgunozerk ozgunozerk requested a review from brozorec November 4, 2025 11:11
brozorec
brozorec approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@brozorec brozorec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ozgunozerk ozgunozerk merged commit 259fdb0 into main Nov 4, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brozorec brozorec brozorec approved these changes

Assignees

@ozgunozerk ozgunozerk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ozgunozerk @brozorec