ReSTIRGI #31
Open
ReSTIRGI #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PearCoding
reviewed
Sep 5, 2022
| @@ -1,4 +1,5 @@ | |||
| // Creates a purely two-sided diffuse BSDF | |||
| // note from Eric: isn't kd in make_bsdf_sample() wrong (no pdf and cos applied)? | |||
Owner
There was a problem hiding this comment.
The weight returned by the make_bsdf_sample is already divided by the pdf. The sampler of the diffuse bsdf has cos/pi. Dividing by it returns only kd.
Author
There was a problem hiding this comment.
Stehe gerade wohl auf dem Schlauch, also beim orennayar bsdf hat man ja folgendes:
color_mulf(eval(gdir, out_dir), 1 / sample.pdf), was als color mitgegeben wird.
Beim purely diffuse bsdf jedoch nur die reflectance, also nur das kd, ohne dass da durch die pdf geteilt wird oder der cosinus multipliziert wird, oder nicht?
Owner
There was a problem hiding this comment.
In orennayar habe ich es einfach nicht selbst ausgerechnet. In diffuse habe ich die optimierung einfach selber gemacht.
PearCoding
added a commit
that referenced
this pull request
Sep 5, 2022
PearCoding
added a commit
that referenced
this pull request
Sep 5, 2022
Co-authored-by: Eric <Windholz.Eric@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.