Skip to content

Revert vanilla behavior changed by e359a87 and b0cd1e0 #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Revert vanilla behavior changed by e359a87 and b0cd1e0 #1938

wants to merge 2 commits into from
+7 −3

Conversation

@TaranDahl
Copy link
Contributor

@TaranDahl TaranDahl commented Oct 30, 2025 •
edited
Loading

@TaranDahl TaranDahl added Minor Minor feature and/or fix, not a lot of changes or they are not significant ⚙️T1 T1 maintainer review is sufficient labels Oct 30, 2025
@TaranDahl TaranDahl mentioned this pull request Oct 30, 2025
Open
5 tasks
@github-actions
Copy link

github-actions bot commented Oct 30, 2025 •
edited
Loading

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@DeathFishAtEase DeathFishAtEase added the No Documentation Needed No documentation needed whatsoever label Nov 2, 2025
@TaranDahl
Copy link
Contributor Author

image

Could you please explain why there is a Hunt mission queued here?
The blame says this was changed 5 years ago by @Belonit in b0cd1e0, requested from @FS-21 .

@Belonit
Copy link
Member

Belonit commented Nov 2, 2025

Maybe @FS-21 knows

@Starkku
Copy link
Contributor

Starkku commented Nov 2, 2025 •
edited
Loading

Hunt has special handling for MCV's where it seeks for free space to deploy at. Might or might not be related.

@TaranDahl
Copy link
Contributor Author

Hunt has special handling for MCV's where it seeks for free space to deploy at. Might or might not be related.

Yes, that's what I find strange. This Hunt mission is for the units generated by undeploy, so it will be deployed again immediately. I can't imagine why this is done at all.

@TaranDahl TaranDahl changed the title Revert vanilla behavior changed by e359a87 Revert vanilla behavior changed by e359a87 and b0cd1e0 Nov 3, 2025
@FS-21
Copy link
Contributor

FS-21 commented Nov 3, 2025 •
edited
Loading

For the age of the commit maybe that code should be part for the mindcontrol fix when the structure was undeployed into vehicle. Why hunt mission? No idea of the details.

@FS-21
Copy link
Contributor

FS-21 commented Nov 3, 2025

image Could you please explain why there is a Hunt mission queued here? The blame says this was changed 5 years ago by @Belonit in [b0cd1e0](https://github.com/Phobos-developers/Phobos/commit/b0cd1e0ffd75094c6bdc5f78309e991571f2a240), requested from @FS-21 .

Testing that binary looks fixed. Let me test the new tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Minor Minor feature and/or fix, not a lot of changes or they are not significant No Documentation Needed No documentation needed whatsoever ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TaranDahl @Belonit @Starkku @FS-21 @DeathFishAtEase