Skip to content

[Conan] Update sparrow version #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[Conan] Update sparrow version #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bed35b3
Update sparrow version for conan
Hind-M Oct 28, 2025
5a9a9ff
Set sparrow with_json_reader option to True
Hind-M Oct 30, 2025
b49e4d3
Use export_json_reader
Hind-M Oct 30, 2025
ba1e471
Use new syntax
Hind-M Oct 30, 2025
588213d
Fix syntax
Hind-M Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/conan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Install conan dependencies
run: |
conan profile detect --force
conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o:a build_tests=True
conan install . --output-folder=build --build=missing -s:a compiler.cppstd=20 -o "&:build_tests=True" -o "sparrow/*:export_json_reader=True"

- name: CMake configuration
run: |
Expand Down
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def configure(self):
self.options.rm_safe("fPIC")

def requirements(self):
self.requires("sparrow/1.0.0")
self.requires("sparrow/1.3.0")
Copy link
Member Author

@Hind-M Hind-M Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the new version for this to work (cf. man-group/sparrow#603).

Copy link
Member

@Alex-PLACET Alex-PLACET Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3 is merged on conan center

Copy link
Member Author

@Hind-M Hind-M Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I meant when the recipe in conan center is updated with transitive_headers set to True for nlohmann_json requirement (cf. error).

self.requires(f"flatbuffers/{self._flatbuffers_version}")
self.requires("lz4/1.9.4")
#self.requires("zstd/1.5.5")
Expand Down
Loading