Full Rebuild (Sync) November 2025: bump ros-distro-mutex to 0.7.0 and build_number to 24 #557
+5,720
−8,695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
Id like to help! :) |
Member
Author
I gave you access to the fork, feel free to push directly there in the |
Contributor
|
Thanks! I pushed a number of (mostly windows) related fixes. Will continue later. |
The upstream source at release/noetic/rosbag/1.17.4-1 now uses conditional compilation (#if BOOST_VERSION < 107200) for boost headers.
Contributor
|
I just tried to fix rosbash but it looks like the zsh implementation has changed quite a bit. I let my AI assistant cobble something together but I dont really trust it enough. |
Contributor
|
Should we try to use |
The upstream source already removed add_compile_options(-std=c++11). Regenerated patch to only add OpenCV find_package and linking.
The upstream source at release/noetic/rosgraph/1.17.4-1 already has Python 3.11+ compatibility handling with conditional logic.
The upstream source at release/noetic/rospack/2.6.4-1 already handles APPLE-specific library exclusion using a package_libraries variable.
The upstream source already has the boost filesystem API updates (fs::extension). Regenerated patch without those already-applied changes.
The upstream source at release/noetic/topic_tools/1.17.4-1 already includes the <thread> header that this patch was adding.
The upstream source at release/noetic/tf2_py/0.7.10-1 already includes the APPLE-specific Python linking and -undefined dynamic_lookup flags.
The upstream source at release/noetic/tf/1.13.4-1 already removed the C++11 checking logic. Regenerated patch with only NO_ERROR and sys/time.h changes.
Member
Author
Done in traversaro@596aa7a . |
Contributor
|
I can have a look at the zsh patch on Monday, but I am also fine with just removing it. |
Refactor run_rattler_build to run recipes individually and report results. Better for debugging.
Ensure console output is UTF-8 and safe on Windows.
Contributor
I had a look, and it indeed changed quite a bit. I cannot get it to work on my workspace. It's only completing files in the current folder. |
Member
Author
Ok for me, do you have any different opinion on this @baszalmstra @ruben-arts ? For reference, the patches were added in #536 and #542 . |
Member
Author
|
In the meanwhile I remove it to actually start the build, we can always re-add back the patch if somebody is interested in that. |
Contributor
|
I have no problems with that, lets get this build going! |
Member
Author
|
First failure: as our patch was merged in ros/geometry#214 and released in https://github.com/ros/geometry/releases/tag/1.13.4, we can just drop it. |
Member
Author
|
New failure: this is something related to dummy packages. |
Member
Author
There was a stupid typo: 4b34637 . |
Member
Author
|
Next error on the error is familiar, but I do not remember a lot about that. |
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
I am note sure about that, but it seems that the Ceres CMake config is getting confused as it is finding something (CUDA?) in your system instead of your rattler-build prefix, and that result in a failure. That is probably a bug in Ceres or CMake, especially around the part in the CeresConfig.cmake file that calls: that should quietly fail. Anyhow, for the purpouse of the build, just avoiding this system interference is enough. To do so, you can either run the build process in a Docker environment, or also pass the |
Interestingly this did not resolve the issue (unless I have to clear some kind of cache for this to work) |
Member
Author
Interesting, I think there are a few ways to debug this:
|
|
Ok. its definitely something to do with my system, running in docker gets the to the same ninja error you shared to above
It does appear to be put in there
Interestingly the CMakeCache.txt also these this lines as the only mention of CUDA in the file: Given it's working in the pipeline and in docker on my system I'm going to chalk this up to some super funky package state on my system. |
Collaborator
|
Linux error: |
Collaborator
|
Windows error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal here is to align noetic with the rest of the repos, switching to a unified
vinca.yamland similar. To be honest, I do not have any interested in Noetic packages it self at the moment, so if anyone more interested in Noetic wants to help here it would be great.fyi @mmoerdijk @TedVanderfeen @ruben-arts @baszalmstra @vmehta-humanoid @nmarticorena @daenny (just tagging the author of recent PRs to the Noetic repo)