WWSTCERT-8242 Add support to frient heat detector #2447
+655
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8d27a56 |
Test Results 71 files 459 suites 0s ⏱️ Results for commit 8d27a56. ♻️ This comment has been updated with latest results. |
greens
reviewed
Oct 8, 2025
| if device:supports_capability(capabilities.smokeDetector) then | ||
| device:emit_event(smokeDetector.smoke.clear()) | ||
| end | ||
| device:send(cluster_base.read_manufacturer_specific_attribute(device, Basic.ID, DEVELCO_BASIC_PRIMARY_SW_VERSION_ATTR, DEVELCO_MANUFACTURER_CODE)) |
greens
changed the title
greens
reviewed
Oct 14, 2025
| @@ -0,0 +1,567 @@ | |||
| -- Copyright 2022 SmartThings | |||
|
We'd like to see a higher code coverage value from the tests. |
…com/marcintyminski/SmartThingsEdgeDrivers into Add-support-to-frient-heat-detector
greens
reviewed
Oct 28, 2025
Comment on lines
+138
to
+143
| if device:supports_capability(capabilities.temperatureAlarm) then | ||
| device:emit_event(temperatureAlarm.temperatureAlarm.cleared()) | ||
| end | ||
| if device:supports_capability(capabilities.smokeDetector) then | ||
| device:emit_event(smokeDetector.smoke.clear()) | ||
| end |
There was a problem hiding this comment.
I believe this branch is where you're lacking code coverage. We have a way to set up delayed events tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests