Recursive dependent fields fix #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnix
changed the title
|
We've been successfully using this branch in production for a couple of weeks without problems. I've been trying to implement some e2e tests to replicate the issue with live components but I'm pretty lost about what would be the correct way to set it up. If someone could help me to set up the environment, I would be more than happy to create the reproducer :) |
|
@devnix I dont' know the exact steps to set up tests, but if you check out the API Platform skeleton this has e2e tests pre-configured, using playwrite… but now I thinkof it, you probably want PHP tests for this repo, right? |
|
Probably yeah, I think I (we?) would prefer to use zenstruck/browser for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could probably fix #25
@ErwannDiagram, @toby-griffiths, I think this pull request would solve our problem. Could you provide feedback about it?
@alcohol, @aesislabs, would you like to check if it solves your case too?
TODO:
src/DynamicFormBuilder.phpdiff since it was vibecoded