- 
                Notifications
    
You must be signed in to change notification settings  - Fork 31
 
ToDo Task Management - Tavan #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… with layout and styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
| 
           Hey tavan sorry but I need a late code review hope you don't mind. This is a really clean and well-organized project. You’ve built a simple but solid task app that uses React, Zustand, and styled-components in a clear and consistent way. Everything feels modular and easy to understand — each file has a clear purpose, and the logic is straightforward. useTaskStore.js TaskForm.jsx A few small tweaks could make it even better. You could disable the button when the input is empty or show a short validation message if someone tries to submit nothing. Adding focus styles to the button and maybe setting a maxLength on the textarea would also improve user experience. Task.jsx One thing to consider is adding keyboard focus styles so users who navigate without a mouse can see where they are. You could also add a title attribute to the icon buttons for tooltips. Other than that, this is a great piece of UI — nothing overcomplicated, just clean React logic. TaskList.jsx Styling and Structure Overall is a good and simple project that is well-coded, visually appealing , and logically sound. It’s obvious you’ve paid attention to structure and readability. The only improvements are small refinements like adding persistence, accessibility focus states, and a bit more UX feedback.  | 
    
Deployed site: https://tthiry-todotaskmanagement.netlify.app