[TF2] Fix prediction issues with Spy watches and cloak #1608
+106
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Spy watch has broken prediction when deploying/holstering, and likewise when adding or removing the cloak conditions. This PR addresses those issues. Specifically it does the following:
m_hOffHandWeaponnot being defined in the send table. This was originally declared as a networked variable, so this was clearly an oversightCTFPlayerSharedrun theOnAddStealthed/OnRemoveStealthedcallbacks in every step of prediction rather than just once per frame, but skips processing particles/sounds/etc to not stack those upItemFramefunctions, which use the player clockVisually, this makes the spy watches not skip their animations or jitter all over the place. It also prevents a view hitch when cloaking/uncloaking while moving.
NOTE: for best results, this should be combined with #1606. The videos were recorded with that PR merged in. Tested with
net_fakelag 100.Before:
hl2_win64_sE0gKeDNFu.mp4
After:
hl2_win64_wzAz5f0bgT.mp4