[WPE][MSE][GStreamer] Fix QuotaExceededError for init segment when no… #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… text limit specified Ignore missing "Text" limit in MSE_MAX_BUFFER_SIZE env when calculating max buffer size for init segment. With current impl, missing any of track type A/V/T from MSE_MAX_BUFFER_SIZE causes WebKit to fallback to default value from HTMLMediaElement/settings that is ~15MB for WPE. Providing higher video and audio limits in the env we can still end up in QuotaExceededError because of that. Assume video and audio limits are enough to calculate accumulative max buffer size for any type of track.
vivienne-w
added a commit
to vivienne-w/WebKit
that referenced
this pull request
Nov 6, 2025
… text limit specified https://bugs.webkit.org/show_bug.cgi?id=302072 Reviewed by NOBODY (OOPS!). Ignore missing "Text" limit in MSE_MAX_BUFFER_SIZE env when calculating max buffer size for init segment. With current impl, missing any of track type A/V/T from MSE_MAX_BUFFER_SIZE causes WebKit to fallback to default value from HTMLMediaElement/settings that is ~15MB for WPE. Providing higher video and audio limits in the env we can still end up in QuotaExceededError because of that. Assume video and audio limits are enough to calculate accumulative max buffer size for any type of track. Original author: Andrzej Surdej <Andrzej_Surdej@comcast.com> See: WebPlatformForEmbedded/WPEWebKit#1578 * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp: (WebCore::SourceBufferPrivateGStreamer::platformMaximumBufferSize const):
vivienne-w
added
the
upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… text limit specified
Ignore missing "Text" limit in MSE_MAX_BUFFER_SIZE env when calculating max buffer size for init segment.
With current impl, missing any of track type A/V/T from MSE_MAX_BUFFER_SIZE causes WebKit to fallback to default value from HTMLMediaElement/settings that is ~15MB for WPE. Providing higher video and audio limits in the env we can still end up in QuotaExceededError because of that.
Assume video and audio limits are enough to calculate accumulative max buffer size for any type of track.
c9318f6