Add in various test GitHub Action workflows #49

dkotter · 2025-10-23T20:28:25Z

Description of the Change

This PR adds in the following GitHub Action workflows:

Run PHPCS
Run PHPStan
Run PHPUnit
Run JS linting (disabled for now)

Also adds in / updates all necessary config files for this workflows and adds in / updates all necessary dependencies.

In addition, there were a handful of failures the above workflows flagged that have now been fixed up, including some PHPCS issues, PHPStan issues and some failing PHPUnit tests.

And last, tries to fix a couple issues with the Pull Request Comments workflow that was merged in #41. This is unfortunately hard to test until these files are merged in as GitHub won't run these workflows from a fork it seems. But I'm hoping these are the last couple changes required there.

Note

The above workflows were all copied from either the Abilities API repo or the MCP Adapter repo. I modified them slightly to work here but for the most part, left things alone. So if there are any changes we would like to make to the workflows or to the configs they use, that can be discussed.

How to test the Change

Ensure all workflows are running and passing on this PR

Test using WordPress Playground

The changes in this pull request can be previewed and tested using this WordPress Playground instance:

Click here to test this pull request.

…CompatWP package

…eded dependencies for this new config. Ensure we use the same version of WordPress across all files

…tup proper config file

… files

…nfig files

github-actions · 2025-10-23T20:28:41Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: dkotter <dkotter@git.wordpress.org>
Co-authored-by: Ref34t <mokhaled@git.wordpress.org>
Co-authored-by: jeffpaul <jeffpaul@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

codecov · 2025-10-23T21:28:40Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

…d the plugin from the current branch, not trunk

dkotter · 2025-10-23T21:57:09Z

.github/workflows/build-plugin-zip.yml

      - name: Checkout code
        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
        with:
-          ref: ${{ github.ref }}


I think with this in place the zip we build is always from trunk instead of the branch. Can't test that without merging this in due to this PR being opened from a fork but if you download the artifact from this PR, you'll see none of the changes made here reflected in that (and this breaks our Playground integration as we had a requirement of WP 6.9, which isn't out yet)

dkotter · 2025-10-23T21:58:01Z

.github/workflows/pull-request-comments.yml

                  data: {
                    resource: 'url',
-                    url: `/plugin-proxy.php?org=WordPress&repo=ai&workflow=Build%20Plugin%20Zip&artifact=ai&pr=${prNumber}`,
+                    url: `/plugin-proxy.php?org=WordPress&repo=ai&workflow=Pull%20Request%20Comments&artifact=ai&pr=${prNumber}`,


Because we call our Build Plugin Zip workflow from within this Pull Request Comments workflow, looks like the workflow name that shows in the API is Pull Request Comments, so updating that to ensure our Playground integration will work (though will also require the change referenced here)

dkotter · 2025-10-23T21:58:33Z

.github/workflows/test.yml

+        permissions:
+            contents: read
+        timeout-minutes: 20
+        if: false  # Temporarily disabled


Disabled for now as we have no JS files and so this workflow will fail

Might be ok to enable unless we feel confident we'll enable once we get JS in here?

My only concern with enabling it is it causes this workflow to always fail even though nothing is actually wrong. I have this noted to come back to so no concern with forgetting to enable this but happy to turn this on now if we want

ai.php

dkotter · 2025-10-23T22:00:31Z

includes/Features/Example_Feature/README.md


 ```php
-add_filter(
-	'ai_feature_enabled',


Looks like at some point the name of this filter was changed and no longer allows you to disable individual features. Didn't look through commit/comment history but wondering if that was intentional?

To be more clear, you can still disable an individual feature using the filter ai_feature_{$this->id}_enabled. But ai_feature_enabled no longer exists, seems to have been replaced with ai_features_enabled (feature vs features) and that filter doesn't pass the individual feature to it, so it's a universal disablement.

@dkotter indeed, the ai_feature_enabled filter was refactored to the features version and now lives in the loader, due to finding that having two different filters was not good enough.

dkotter · 2025-10-23T22:01:19Z

tests/Integration/Includes/Features/Example_Feature/Example_FeatureTest.php

 		$modified_title = apply_filters( 'document_title_parts', $title_parts );

-		$this->assertEquals( 'My Site [AI]', $modified_title['site'] );
+		$this->assertEquals( 'My Site [AI] [AI]', $modified_title['site'] );


This fixes the test but not sure why the [AI] part gets added twice. Seems like a likely bug in our Example Feature. Need to look closer at that

Fixed in a5c7acc. Features were being initialized twice when running tests, resulting in the feature being applied twice (and thus seeing the double [AI] label). Seems to just be an issue in the tests but if anyone else wants to take a look, may be worth a second set of eyes to ensure there isn't a bug in our feature loader that would allow features to be loaded twice in normal circumstances

ai.php

dkotter added 7 commits October 23, 2025 13:11

Add a GitHub Action workflow to run PHPCS on each PR. Install the PHP…

9c7d4ca

…CompatWP package

Update our PHPCS config to match the other AI plugins. Install the ne…

ba618bd

…eded dependencies for this new config. Ensure we use the same version of WordPress across all files

Fix all PHPCS errors

ee1556a

Add a workflow to run PHPStan. Bring in necessary dependencies and se…

167913f

…tup proper config file

Fix errors PHPStan was reporting

707af82

Add workflow to lint JS files, with necessary dependencies and config…

37ed331

… files

Add workflow to run PHPUnit tests, with necessary dependencies and co…

6e05f2a

…nfig files

dkotter changed the title ~~Add various test workflows~~ WIP: Add various test workflows Oct 23, 2025

dkotter added 3 commits October 23, 2025 15:11

Ensure the tests/_output directory isn't ignored

203598e

Disable jslint for now as we have no JS files

0c7f3e7

Fix unit tests; update docs

b2c487d

Update the workflow name used to build the plugin zip. Ensure we buil…

201b66e

…d the plugin from the current branch, not trunk

dkotter self-assigned this Oct 23, 2025

dkotter commented Oct 23, 2025

View reviewed changes

ai.php Show resolved Hide resolved

dkotter commented Oct 23, 2025

View reviewed changes

dkotter changed the title ~~WIP: Add various test workflows~~ Add in various test GitHub Action workflows Oct 23, 2025

jeffpaul added this to the 0.1.0 milestone Oct 24, 2025

dkotter mentioned this pull request Oct 24, 2025

Pull in the various AI dependencies we'll be using #50

Merged

jeffpaul reviewed Oct 27, 2025

View reviewed changes

ai.php Show resolved Hide resolved

jeffpaul approved these changes Oct 27, 2025

View reviewed changes

dkotter added 2 commits October 27, 2025 14:33

Merge branch 'trunk' into add/lint-workflows

ec6938b

Prevent our example feature from being initialized twice in our tests

a5c7acc

dkotter merged commit ce33a83 into WordPress:trunk Oct 28, 2025
23 checks passed

dkotter deleted the add/lint-workflows branch October 28, 2025 17:24

Uh oh!

Add in various test GitHub Action workflows #49

Add in various test GitHub Action workflows #49

Conversation

dkotter commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the Change

How to test the Change

Test using WordPress Playground

Uh oh!

github-actions bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 23, 2025

Welcome to Codecov 🎉

Uh oh!

dkotter Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkotter Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dkotter commented Oct 23, 2025 •

edited

Loading

github-actions bot commented Oct 23, 2025 •

edited

Loading

dkotter Oct 23, 2025 •

edited

Loading

dkotter Oct 23, 2025 •

edited

Loading