No changes needed - code already uses count() > 0 per feedback
#278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review feedback on PR #276 regarding the use of
empty()vscount() > 0for array emptiness checks.Context
A bot suggested changing
count( $unkwnown_columns ) > 0to! empty( $unkwnown_columns )for readability. @JanJakes objected, noting thatempty()is problematic and potentially slower.Resolution
The code already uses
count( $unkwnown_columns ) > 0in commit 8bd98ae. The bot's suggestion was never implemented. No code changes required.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.