-
-
Notifications
You must be signed in to change notification settings - Fork 48
Rewritten assert statements for more explicit checks #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Can you add a reference link in your commit message before your signoff: |
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you amend your commit to add your DCO signoff?
Note that the other test failures may not be your making, but rather because of #576
|
@pombredanne |
| lic_score = about.license_score.value | ||
| assert len(lic_key) == len(lic_name) | ||
| assert len(lic_key) == len(lic_score) | ||
| if len(lic_key) != len(lic_name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be you can extract a variable?
| if len(lic_key) != len(lic_name): | |
| len_lics = len(lic_key) | |
| if len_lics != len(lic_name): |
and then use it in the messages and other tests below?
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could you squash your commits, rewrite a proper commit message as explained in our documentation, add your DCO signoff, and force push?
|
Yeah I tried that but force pushing didn't seem to work for me. Let me do it again. |
Fixes issue:
I have changed the assert statements to if and raise statements. It was a good first issue.