Skip to content

Conversation

@Dhruv276R
Copy link

@Dhruv276R Dhruv276R commented Jan 14, 2025

Fixes issue:

I have changed the assert statements to if and raise statements. It was a good first issue.

@pombredanne
Copy link
Member

Can you add a reference link in your commit message before your signoff:
Reference: https://github.com/aboutcode-org/aboutcode/issues/175

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you amend your commit to add your DCO signoff?

Note that the other test failures may not be your making, but rather because of #576

@Dhruv276R
Copy link
Author

Dhruv276R commented Jan 18, 2025

@pombredanne
Can you tell me what to do exactly? I am new in open source and willing to make better contributions

lic_score = about.license_score.value
assert len(lic_key) == len(lic_name)
assert len(lic_key) == len(lic_score)
if len(lic_key) != len(lic_name):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be you can extract a variable?

Suggested change
if len(lic_key) != len(lic_name):
len_lics = len(lic_key)
if len_lics != len(lic_name):

and then use it in the messages and other tests below?

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you squash your commits, rewrite a proper commit message as explained in our documentation, add your DCO signoff, and force push?

@Dhruv276R
Copy link
Author

Yeah I tried that but force pushing didn't seem to work for me. Let me do it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants