Skip to content

Conversation

@ashleyfrieze
Copy link

Description:
We have a requirement to add an advisory label to PRs where there's missing documentation change or missing unit tests.

This seems to fit into the labeler model via a new top level key none.

Please consider this PR for inclusion in this useful action.

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@ashleyfrieze ashleyfrieze requested a review from a team as a code owner September 17, 2025 15:38
Copilot AI review requested due to automatic review settings September 17, 2025 15:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new none option to the labeler action that enables inverse matching for labels. This allows users to apply labels when certain conditions are NOT met, such as when documentation or test files are missing from a PR.

  • Adds none matching option to complement existing any and all options
  • Updates type definitions and configuration parsing to support the new option
  • Adds comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/labeler.ts Implements the core logic for none matching using inverse of checkAny
src/api/get-label-configs.ts Adds none to type definitions and configuration parsing
tests/labeler.test.ts Adds test cases for both positive and negative none matching scenarios
tests/fixtures/all_options.yml Updates test fixture to include none configuration examples
README.md Documents the new none option with examples and usage guidance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

ashleyfrieze and others added 4 commits September 17, 2025 17:48
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant