Skip to content

Conversation

@skateball
Copy link
Contributor

@skateball skateball commented Oct 15, 2025

Description:
The URL to the Version JSON of the available SapMachine releases will change. Therefore we want to update it. Please merge soon.
No documentation and no tests required.

The backport to releases/v4 is #939
Thx&Best Regards
Christian@SapMachine-Team at SAP

Related issue:
#937

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@skateball skateball requested a review from a team as a code owner October 15, 2025 15:11
Copy link
Contributor

@Shegox Shegox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the original creator of #614 I can confirm that the URL change is intentional and sapmachine.io is as well controlled by the SapMachine team and linked as well on https://github.com/SAP/SAPmachine

@skateball skateball changed the title Update SapMachine URLs Update SapMachine URLs to main Oct 15, 2025
@mahabaleshwars
Copy link
Contributor

Hi @skateball,

Thanks for this PR! I noticed that only the TypeScript source file (src/distributions/sapmachine/installer.ts) has been updated, but the compiled distribution files are missing.

Since GitHub Actions run the pre-built JavaScript directly, you'll need to run the build command and commit the generated files:
npm run build

This will update dist/setup/index.js with your URL changes. Without these compiled files, the action will continue using the old URLs at runtime.

@skateball
Copy link
Contributor Author

Hi @mahabaleshwars ,
done. the backport to releases/v4 in in https://github.com/actions/setup-java/pull/939/files
best regards Christian

mahabaleshwars
mahabaleshwars previously approved these changes Oct 23, 2025
Copy link

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small thing that should be corrected.

let fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://sapmachine.io/assets/data/sapmachine-releases-all.json');
if (!fetchedReleasesJson) {
fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://api.github.com/repos/SAP/SapMachine/contents/assets/data/sapmachine-releases-all.json?ref=gh-pages', (0, util_1.getGitHubHttpHeaders)());
fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json', (0, util_1.getGitHubHttpHeaders)());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json', (0, util_1.getGitHubHttpHeaders)());
fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json');

I think the GitHub Headers are not needed any more for the Backup URL since it is not using the GitHub API but also just downloading a plain json file from a URL.

aparnajyothi-y
aparnajyothi-y previously approved these changes Oct 24, 2025
Copy link

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@mahabaleshwars
Copy link
Contributor

Hi @skateball, could you please take a look at the failing checks and resolve the issues? Let me know if you need any help or clarification on the errors. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants