-
Couldn't load subscription status.
- Fork 814
Update SapMachine URLs to main #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the original creator of #614 I can confirm that the URL change is intentional and sapmachine.io is as well controlled by the SapMachine team and linked as well on https://github.com/SAP/SAPmachine
|
Hi @skateball, Thanks for this PR! I noticed that only the TypeScript source file (src/distributions/sapmachine/installer.ts) has been updated, but the compiled distribution files are missing. Since GitHub Actions run the pre-built JavaScript directly, you'll need to run the build command and commit the generated files: This will update dist/setup/index.js with your URL changes. Without these compiled files, the action will continue using the old URLs at runtime. |
|
Hi @mahabaleshwars , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a small thing that should be corrected.
dist/setup/index.js
Outdated
| let fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://sapmachine.io/assets/data/sapmachine-releases-all.json'); | ||
| if (!fetchedReleasesJson) { | ||
| fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://api.github.com/repos/SAP/SapMachine/contents/assets/data/sapmachine-releases-all.json?ref=gh-pages', (0, util_1.getGitHubHttpHeaders)()); | ||
| fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json', (0, util_1.getGitHubHttpHeaders)()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json', (0, util_1.getGitHubHttpHeaders)()); | |
| fetchedReleasesJson = yield this.fetchReleasesFromUrl('https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json'); |
I think the GitHub Headers are not needed any more for the Backup URL since it is not using the GitHub API but also just downloading a plain json file from a URL.
fcb4621
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
|
Hi @skateball, could you please take a look at the failing checks and resolve the issues? Let me know if you need any help or clarification on the errors. Thank you! |
Description:
The URL to the Version JSON of the available SapMachine releases will change. Therefore we want to update it. Please merge soon.
No documentation and no tests required.
The backport to releases/v4 is #939
Thx&Best Regards
Christian@SapMachine-Team at SAP
Related issue:
#937
Check list: