Implement Ledger #231
Open
Implement Ledger #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesitor
force-pushed
the
andres-feature-implement_ledger_wallet
branch
from
422e9b0 to
ef69187
Compare
Solution: Implement Ledger use on SDK to allow using them.
1yam
force-pushed
the
andres-feature-implement_ledger_wallet
branch
from
ef69187 to
9b8d8b6
Compare
|
Failed to retrieve llama text: POST 503: 503 Service UnavailableNo server is available to handle this request. |
odesenfans
requested changes
Nov 3, 2025
src/aleph/sdk/conf.py
Outdated
| address: Optional[str] = None | ||
|
|
||
| model_config = SettingsConfigDict(use_enum_values=True) | ||
| # model_config = SettingsConfigDict(use_enum_values=True) |
odesenfans
requested changes
Nov 5, 2025
Contributor
odesenfans
left a comment
odesenfans
left a comment
There was a problem hiding this comment.
Looks like this needs a refactoring of base classes the class hierarchy make sense.
…odel validator to ensure retro compatibility
EthAccount is the Account using Private key
…nt and LedgerEthAccount
…untFromPrivateKey
odesenfans
requested changes
Nov 7, 2025
odesenfans
previously approved these changes
Nov 7, 2025
Contributor
odesenfans
left a comment
odesenfans
left a comment
There was a problem hiding this comment.
A few nitpicks here and there but LGTM
| logger = logging.getLogger(__name__) | ||
|
|
||
| T = TypeVar("T", bound=AccountFromPrivateKey) | ||
| AccountTypes: TypeAlias = Union["AccountFromPrivateKey", "HardwareAccount"] |
Contributor
There was a problem hiding this comment.
Nitpick: should be AccountType as it's either one or the other.
Member
There was a problem hiding this comment.
Well we have already an AccountType i put AccountTypes since it's 2 accounts Union to don't have 2 time AccountType
Co-authored-by: Olivier Desenfans <desenfans.olivier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Ledger wallet users cannot use Aleph to send transactions.
Solution: Implement Ledger use on SDK to allow using them.