Enforce ktlint max-line-length with Spotless gradle/init.gradle.kts #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
cartland
force-pushed
the
cartland/line-length
branch
from
48691b6 to
3f1660d
Compare
|
I am supportive of this, but I don't see how the modification of the lint rules follow the changes that are suggested in the PR - are there some changes that are manual instead of generated by the linter? Examples on the commits. |
devbridie
reviewed
Nov 6, 2025
| .wrapContentWidth() | ||
| .padding(8.dp), | ||
| style = MaterialTheme.typography.titleSmall | ||
| style = MaterialTheme.typography.titleSmall, |
devbridie
reviewed
Nov 6, 2025
| } | ||
| composable( | ||
| "details/{id}", | ||
| route = "details/{id}", |
devbridie
reviewed
Nov 6, 2025
| ) { | ||
| Icon( | ||
| painter = if (isPressed) painterResource(id = selectedImage) else painterResource(id = unselectedImage), | ||
| painter = if (isPressed) { |
devbridie
reviewed
Nov 6, 2025
| shape = SurfaceEntity.Shape.Quad(FloatSize2d(1.0f, 1.0f)), | ||
| surfaceProtection = SurfaceEntity.SurfaceProtection.SURFACE_PROTECTION_PROTECTED | ||
| surfaceProtection = | ||
| SurfaceEntity.SurfaceProtection.SURFACE_PROTECTION_PROTECTED |
There was a problem hiding this comment.
Is this correct? I would expect an indent here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snippets from this repository are included in documentation at developer.android.com. Long lines are difficult to read in these snippets (and in general). We previously disabled
ktlintformax-line-lengthbecause it was difficult to enforce across all snippets. Now we're seeing the challenge appear in the documentation publishing process. Since the snippet line length is not enforced in the code base, teams are adding manual warnings and checks at publishing time to make sure that the line length is not too long.I am creating this pull request to show which changes will allow
max-line-lengthto be enforced. I will ask teams to review these changes to make sure they don't cause other side effects in the documentation or build process. After everyone is satisfied, we can enforce the line lengths.